test: skip sea tests on x64 macOS by joyeecheung · Pull Request #60250 · nodejs/node

joyeecheung · 2025-10-13T20:58:14Z

test: move sea tests into test/sea

This makes skipping/running these tests easier to manage with a
dedicated test runner that can be tweaked for SEA.

test: skip sea tests on x64 macOS

It's unlikely that anyone would invest in fixing them on x64 macOS in the
near future, now that x64 macOS is being phased out. Simply skip them
for now.

Refs: #59553

richardlau

Can you also migrate

node/test/sequential/sequential.status

Lines 74 to 93 in 59b70e5

    
           [$system==linux && $arch==ppc64] 
        
           # https://github.com/nodejs/node/issues/59561 
        
           test-single-executable-application: SKIP 
        
           test-single-executable-application-assets: SKIP 
        
           test-single-executable-application-assets-raw: SKIP 
        
           test-single-executable-application-asset-keys-empty: SKIP 
        
           test-single-executable-application-asset-keys: SKIP 
        
           test-single-executable-application-disable-experimental-sea-warning: SKIP 
        
           test-single-executable-application-empty: SKIP 
        
           test-single-executable-application-exec-argv: SKIP 
        
           test-single-executable-application-exec-argv-empty: SKIP 
        
           test-single-executable-application-exec-argv-extension-cli: SKIP 
        
           test-single-executable-application-exec-argv-extension-env: SKIP 
        
           test-single-executable-application-exec-argv-extension-none: SKIP 
        
           test-single-executable-application-inspect-in-sea-flags: SKIP 
        
           test-single-executable-application-inspect: SKIP 
        
           test-single-executable-application-snapshot: SKIP 
        
           test-single-executable-application-snapshot-and-code-cache: SKIP 
        
           test-single-executable-application-snapshot-worker: SKIP 
        
           test-single-executable-application-use-code-cache: SKIP

from sequential.status to the new sea.status?

test/sea/sea.status

codecov · 2025-10-13T23:40:28Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.56%. Comparing base (db0121b) to head (f14e663).
⚠️ Report is 42 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #60250      +/-   ##
==========================================
+ Coverage   88.53%   88.56%   +0.02%     
==========================================
  Files         704      704              
  Lines      208087   208322     +235     
  Branches    40010    40037      +27     
==========================================
+ Hits       184239   184500     +261     
+ Misses      15866    15863       -3     
+ Partials     7982     7959      -23

see 62 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

joyeecheung · 2025-10-15T11:42:35Z

Added the missing Linux PPC64 skips and fixed the linter complaints (seems to be only activated on the touched files). Can you take another look? Thanks @richardlau

joyeecheung · 2025-10-15T11:46:07Z

Not sure where this linter comes from, but it's not correct:

==> Executing Duplicated Pattern Checker (39.243µs)
    Check OK
==> Executing File Exist Checker (248.206398ms)
    [err] line 161: "/test/parallel/test-single-executable-*" does not match any files in repository
    [err] line 162: "/test/sequential/test-single-executable-*" does not match any files in repository

joyeecheung · 2025-10-15T11:46:49Z

Oh right, it's the codeowner file that needs to be updated..updating

nodejs-github-bot · 2025-10-15T11:54:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/69738/

nodejs-github-bot · 2025-10-15T20:54:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/69746/

nodejs-github-bot · 2025-10-15T22:25:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/69750/

nodejs-github-bot · 2025-10-15T23:21:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/69751/

It's unlikely that anyone would invest in fixing them on x64 macOS in the near future, now that x64 macOS is being phased out. Simply skip them for now. PR-URL: nodejs#60250 Refs: nodejs#59553 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

joyeecheung · 2025-10-17T10:53:52Z

Fixed the commit message line length and landed manually in c2f3c21...9e8c753

This makes skipping/running these tests easier to manage with a dedicated test runner that can be tweaked for SEA. PR-URL: #60250 Refs: #59553 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

It's unlikely that anyone would invest in fixing them on x64 macOS in the near future, now that x64 macOS is being phased out. Simply skip them for now. PR-URL: #60250 Refs: #59553 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

This makes skipping/running these tests easier to manage with a dedicated test runner that can be tweaked for SEA. PR-URL: #60250 Refs: #59553 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

It's unlikely that anyone would invest in fixing them on x64 macOS in the near future, now that x64 macOS is being phased out. Simply skip them for now. PR-URL: #60250 Refs: #59553 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

This makes skipping/running these tests easier to manage with a dedicated test runner that can be tweaked for SEA. PR-URL: #60250 Refs: #59553 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

It's unlikely that anyone would invest in fixing them on x64 macOS in the near future, now that x64 macOS is being phased out. Simply skip them for now. PR-URL: #60250 Refs: #59553 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [node](https://nodejs.org) ([source](https://github.com/nodejs/node)) | minor | `25.0.0` -> `25.1.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>nodejs/node (node)</summary> ### [`v25.1.0`](https://github.com/nodejs/node/releases/tag/v25.1.0): 2025-10-28, Version 25.1.0 (Current), @aduh95 [Compare Source](nodejs/node@v25.0.0...v25.1.0) ##### Notable Changes - \[[`4395fe14b9`](nodejs/node@4395fe14b9)] - **(SEMVER-MINOR)** **http**: add optimizeEmptyRequests server option (Rafael Gonzaga) [#59778](nodejs/node#59778) - \[[`2e55c6ad04`](nodejs/node@2e55c6ad04)] - **(SEMVER-MINOR)** **sqlite**: allow setting defensive flag (Bart Louwers) [#60217](nodejs/node#60217) - \[[`f437204491`](nodejs/node@f437204491)] - **(SEMVER-MINOR)** **src**: add watch config namespace (Marco Ippolito) [#60178](nodejs/node#60178) ##### Commits - \[[`bb27766bd5`](nodejs/node@bb27766bd5)] - **benchmark**: improve cpu.sh for safety and usability (Nam Yooseong) [#60162](nodejs/node#60162) - \[[`e600711c20`](nodejs/node@e600711c20)] - **benchmark**: add benchmark for leaf source text modules (Joyee Cheung) [#60205](nodejs/node#60205) - \[[`1bbcdf9039`](nodejs/node@1bbcdf9039)] - **benchmark**: add vm.SourceTextModule benchmark (Joyee Cheung) [#59396](nodejs/node#59396) - \[[`22fa6bd28b`](nodejs/node@22fa6bd28b)] - **build**: ibmi follow aix visibility (SRAVANI GUNDEPALLI) [#60360](nodejs/node#60360) - \[[`931028400e`](nodejs/node@931028400e)] - **build**: use call command when calling python configure (Jacob Nichols) [#60098](nodejs/node#60098) - \[[`17fde3f3d1`](nodejs/node@17fde3f3d1)] - **build**: build v8 with -fvisibility=hidden -fvisibility-inlines-hidden (Joyee Cheung) [#56290](nodejs/node#56290) - \[[`04cc7aae5e`](nodejs/node@04cc7aae5e)] - **build**: remove V8\_COMPRESS\_POINTERS\_IN\_ISOLATE\_CAGE defs (Joyee Cheung) [#60296](nodejs/node#60296) - \[[`8a2053060d`](nodejs/node@8a2053060d)] - **crypto**: update root certificates to NSS 3.116 (Node.js GitHub Bot) [#59956](nodejs/node#59956) - \[[`fe91c0f755`](nodejs/node@fe91c0f755)] - **deps**: update simdjson to 4.0.7 (Node.js GitHub Bot) [#59883](nodejs/node#59883) - \[[`aacfc0d212`](nodejs/node@aacfc0d212)] - **deps**: update corepack to 0.34.1 (Node.js GitHub Bot) [#60314](nodejs/node#60314) - \[[`8596891a71`](nodejs/node@8596891a71)] - **deps**: update inspector\_protocol to [`af7f5a8`](nodejs/node@af7f5a8) (Node.js GitHub Bot) [#60312](nodejs/node#60312) - \[[`21bcd0eb2f`](nodejs/node@21bcd0eb2f)] - **deps**: V8: cherry-pick [`3d0f462`](nodejs/node@3d0f462a17ff) (Joyee Cheung) [#59396](nodejs/node#59396) - \[[`673558501c`](nodejs/node@673558501c)] - **deps**: update googletest to [`279f847`](nodejs/node@279f847) (Node.js GitHub Bot) [#60219](nodejs/node#60219) - \[[`425a1879b1`](nodejs/node@425a1879b1)] - **doc**: mention more codemods in `deprecations.md` (Augustin Mauroy) [#60243](nodejs/node#60243) - \[[`563e1317f3`](nodejs/node@563e1317f3)] - **doc**: remove unnecessary statement of web storage (Deokjin Kim) [#60363](nodejs/node#60363) - \[[`064c8c5cfd`](nodejs/node@064c8c5cfd)] - **doc**: add missing CAA type to dns.resolveAny() & dnsPromises.resolveAny() (Jimmy Leung) [#58899](nodejs/node#58899) - \[[`99e357af35`](nodejs/node@99e357af35)] - **doc**: use `any` for `worker_threads.Worker` 'error' event argument `err` (Jonas Geiler) [#60300](nodejs/node#60300) - \[[`8ccff0d934`](nodejs/node@8ccff0d934)] - **doc**: update decorator documentation to reflect actual policy (Muhammad Salman Aziz) [#60288](nodejs/node#60288) - \[[`bac70c6ef3`](nodejs/node@bac70c6ef3)] - **doc**: document wildcard supported by tools/test.py (Joyee Cheung) [#60265](nodejs/node#60265) - \[[`8492bc6a88`](nodejs/node@8492bc6a88)] - **doc**: add --heap-snapshot-on-oom to useful v8 flag (jakecastelli) [#60260](nodejs/node#60260) - \[[`0f0d3c0e47`](nodejs/node@0f0d3c0e47)] - **doc**: fix `blob.bytes()` heading level (XTY) [#60252](nodejs/node#60252) - \[[`8c8525cf93`](nodejs/node@8c8525cf93)] - **doc**: fix not working code example in vm docs (Artur Gawlik) [#60224](nodejs/node#60224) - \[[`8a6de3866c`](nodejs/node@8a6de3866c)] - **doc, assert**: correct order of changes entries (Gerhard Stöbich) [#60304](nodejs/node#60304) - \[[`6bacb6555a`](nodejs/node@6bacb6555a)] - **doc, module**: change async customization hooks to experimental (Gerhard Stöbich) [#60302](nodejs/node#60302) - \[[`6f3b16df16`](nodejs/node@6f3b16df16)] - **esm**: use index-based resolution callbacks (Joyee Cheung) [#59396](nodejs/node#59396) - \[[`95644a432c`](nodejs/node@95644a432c)] - **http**: lazy allocate cookies array (Robert Nagy) [#59734](nodejs/node#59734) - \[[`4395fe14b9`](nodejs/node@4395fe14b9)] - **(SEMVER-MINOR)** **http**: add optimizeEmptyRequests server option (Rafael Gonzaga) [#59778](nodejs/node#59778) - \[[`f1aa1eaaf5`](nodejs/node@f1aa1eaaf5)] - **inspector**: add network payload buffer size limits (Chengzhong Wu) [#60236](nodejs/node#60236) - \[[`64fc625bf9`](nodejs/node@64fc625bf9)] - **inspector**: support handshake response for websocket inspection (Shima Ryuhei) [#60225](nodejs/node#60225) - \[[`0ecbb806a8`](nodejs/node@0ecbb806a8)] - **lib**: fix typo in createBlobReaderStream (SeokHun) [#60132](nodejs/node#60132) - \[[`ffec5927fd`](nodejs/node@ffec5927fd)] - **meta**: fix typo in test-shared workflow name (Ronit Sabhaya) [#60321](nodejs/node#60321) - \[[`a02897e157`](nodejs/node@a02897e157)] - **meta**: move one or more collaborators to emeritus (Node.js GitHub Bot) [#60325](nodejs/node#60325) - \[[`59223a7831`](nodejs/node@59223a7831)] - **meta**: loop userland-migrations in deprecations (Chengzhong Wu) [#60299](nodejs/node#60299) - \[[`2d48d17696`](nodejs/node@2d48d17696)] - **module**: refactor and clarify async loader hook customizations (Joyee Cheung) [#60278](nodejs/node#60278) - \[[`be1b84fd93`](nodejs/node@be1b84fd93)] - **module**: handle null source from async loader hooks in sync hooks (Joyee Cheung) [#59929](nodejs/node#59929) - \[[`063fbd87d3`](nodejs/node@063fbd87d3)] - **msi**: fix WiX warnings (Stefan Stojanovic) [#60251](nodejs/node#60251) - \[[`2e55c6ad04`](nodejs/node@2e55c6ad04)] - **(SEMVER-MINOR)** **sqlite**: allow setting defensive flag (Bart Louwers) [#60217](nodejs/node#60217) - \[[`dc93d6988a`](nodejs/node@dc93d6988a)] - **src**: fix timing of snapshot serialize callback (Joyee Cheung) [#60434](nodejs/node#60434) - \[[`267e1b3817`](nodejs/node@267e1b3817)] - **src**: add COUNT\_GENERIC\_USAGE utility for tests (Joyee Cheung) [#60434](nodejs/node#60434) - \[[`4a5d7a4c2a`](nodejs/node@4a5d7a4c2a)] - **src**: conditionally disable source phase imports by default (Shelley Vohr) [#60364](nodejs/node#60364) - \[[`f437204491`](nodejs/node@f437204491)] - **(SEMVER-MINOR)** **src**: add watch config namespace (Marco Ippolito) [#60178](nodejs/node#60178) - \[[`36837fa0f9`](nodejs/node@36837fa0f9)] - **src**: use cached primordials\_string (Sohyeon Kim) [#60255](nodejs/node#60255) - \[[`df8396ad37`](nodejs/node@df8396ad37)] - **src**: replace Environment::GetCurrent with args.GetIsolate (Sohyeon Kim) [#60256](nodejs/node#60256) - \[[`5dd670b2b9`](nodejs/node@5dd670b2b9)] - **src**: initial enablement of IsolateGroups (James M Snell) [#60254](nodejs/node#60254) - \[[`afdb362933`](nodejs/node@afdb362933)] - **src**: use `Utf8Value` and `TwoByteValue` instead of V8 helpers (Anna Henningsen) [#60244](nodejs/node#60244) - \[[`a40e533e72`](nodejs/node@a40e533e72)] - **src**: add a default branch for module phase (Chengzhong Wu) [#60261](nodejs/node#60261) - \[[`42729f07ee`](nodejs/node@42729f07ee)] - **src**: stop using deprecated v8::Context::GetIsolate (Michaël Zasso) [#60223](nodejs/node#60223) - \[[`7a6542c205`](nodejs/node@7a6542c205)] - **test**: skip failing test on macOS 15.7+ (Antoine du Hamel) [#60419](nodejs/node#60419) - \[[`29a5855a4f`](nodejs/node@29a5855a4f)] - **test**: ensure assertions are reachable in `test/addons` (Antoine du Hamel) [#60142](nodejs/node#60142) - \[[`12773d19c4`](nodejs/node@12773d19c4)] - **test**: increase debugger waitFor timeout on macOS (Chengzhong Wu) [#60367](nodejs/node#60367) - \[[`0b38de3e9e`](nodejs/node@0b38de3e9e)] - **test**: put helper in test-runner-output into common (Joyee Cheung) [#60330](nodejs/node#60330) - \[[`6de2407c44`](nodejs/node@6de2407c44)] - **test**: fix small compile warning in test\_network\_requests\_buffer.cc (xiaocainiao633) [#60281](nodejs/node#60281) - \[[`4b23ac8613`](nodejs/node@4b23ac8613)] - **test**: fix status when compiled without inspector (Antoine du Hamel) [#60289](nodejs/node#60289) - \[[`a07f32e326`](nodejs/node@a07f32e326)] - **test**: split test-runner-watch-mode-kill-signal (Joyee Cheung) [#60298](nodejs/node#60298) - \[[`30451d32d7`](nodejs/node@30451d32d7)] - **test**: fix incorrect calculation in test-perf-hooks.js (Joyee Cheung) [#60271](nodejs/node#60271) - \[[`e3c3b48f1c`](nodejs/node@e3c3b48f1c)] - **test**: ignore EPIPE errors in https proxy invalid URL test (Joyee Cheung) [#60269](nodejs/node#60269) - \[[`405a9c4c5f`](nodejs/node@405a9c4c5f)] - **test**: parallelize test-without-async-context-frame correctly (Joyee Cheung) [#60273](nodejs/node#60273) - \[[`ffeebebc71`](nodejs/node@ffeebebc71)] - **test**: make test-worker-prof more tolerant (Joyee Cheung) [#60272](nodejs/node#60272) - \[[`26b01bf170`](nodejs/node@26b01bf170)] - **test**: skip sea tests on x64 macOS (Joyee Cheung) [#60250](nodejs/node#60250) - \[[`8caae1a05b`](nodejs/node@8caae1a05b)] - **test**: move sea tests into test/sea (Joyee Cheung) [#60250](nodejs/node#60250) - \[[`3d183e3e9f`](nodejs/node@3d183e3e9f)] - **test,crypto**: fix conditional SHA3-\* skip on BoringSSL (Filip Skokan) [#60379](nodejs/node#60379) - \[[`e83dbcba94`](nodejs/node@e83dbcba94)] - **test,crypto**: sha3 algorithms aren't supported with BoringSSL (Shelley Vohr) [#60374](nodejs/node#60374) - \[[`3d89331496`](nodejs/node@3d89331496)] - **test\_runner**: use module.registerHooks in module mocks (Joyee Cheung) [#60326](nodejs/node#60326) - \[[`377e8ce85a`](nodejs/node@377e8ce85a)] - **tls**: avoid external memory leak on invalid protocol versions (Shelley Vohr) [#60390](nodejs/node#60390) - \[[`ae4858c1f6`](nodejs/node@ae4858c1f6)] - **tools**: add an option to generate lighter archives (Antoine du Hamel) [#60294](nodejs/node#60294) - \[[`cb615b1a2e`](nodejs/node@cb615b1a2e)] - **tools**: skip test-shared workflow for draft MRs (Michaël Zasso) [#60365](nodejs/node#60365) - \[[`03b034731e`](nodejs/node@03b034731e)] - **tools**: disable inspector on macOS-shared to reduce flakiness (Antoine du Hamel) [#60320](nodejs/node#60320) - \[[`f402b4e1d1`](nodejs/node@f402b4e1d1)] - **tools**: show diff alongside the error in Nix linter (Antoine du Hamel) [#60301](nodejs/node#60301) - \[[`5d5c8483fb`](nodejs/node@5d5c8483fb)] - **tools**: run CI with shared libs on GHA (Antoine du Hamel) [#60121](nodejs/node#60121) - \[[`e8fdd8d2e8`](nodejs/node@e8fdd8d2e8)] - **tools**: update gyp-next to 0.20.5 (Node.js GitHub Bot) [#60313](nodejs/node#60313) - \[[`6e8b029a21`](nodejs/node@6e8b029a21)] - **tools**: limit inspector protocol MR title length (Chengzhong Wu) [#60324](nodejs/node#60324) - \[[`a5073086c6`](nodejs/node@a5073086c6)] - **tools**: fix inspector\_protocol updater (Chengzhong Wu) [#60277](nodejs/node#60277) - \[[`47fa765bff`](nodejs/node@47fa765bff)] - **tools**: optimize wildcard execution in tools/test.py (Joyee Cheung) [#60266](nodejs/node#60266) - \[[`11ebb0447d`](nodejs/node@11ebb0447d)] - **tools**: add C++ lint rule to avoid using `String::Utf8Value` (Anna Henningsen) [#60244](nodejs/node#60244) - \[[`14f3189670`](nodejs/node@14f3189670)] - **tools**: add inspector\_protocol updater (Chengzhong Wu) [#60245](nodejs/node#60245) - \[[`ef4c596fc6`](nodejs/node@ef4c596fc6)] - **typings**: add missing properties and method in Worker (Woohyun Sung) [#60257](nodejs/node#60257) - \[[`09ae6fc065`](nodejs/node@09ae6fc065)] - **typings**: add missing properties in HTTPParser (Woohyun Sung) [#60257](nodejs/node#60257) - \[[`9ecaf41f8e`](nodejs/node@9ecaf41f8e)] - **typings**: delete undefined property in ConfigBinding (Woohyun Sung) [#60257](nodejs/node#60257) - \[[`4a86016e86`](nodejs/node@4a86016e86)] - **util**: use more defensive code when inspecting error objects (Antoine du Hamel) [#60139](nodejs/node#60139) - \[[`9e6d6cec59`](nodejs/node@9e6d6cec59)] - **util**: mark special properties when inspecting them (Ruben Bridgewater) [#60131](nodejs/node#60131) - \[[`79b2387fd9`](nodejs/node@79b2387fd9)] - **vm**: make vm.Module.evaluate() conditionally synchronous (Joyee Cheung) [#60205](nodejs/node#60205) - \[[`e5559f3be3`](nodejs/node@e5559f3be3)] - **win**: upgrade Visual Studio workload from 2019 to 2022 (Jiawen Geng) [#60318](nodejs/node#60318) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

This makes skipping/running these tests easier to manage with a dedicated test runner that can be tweaked for SEA. PR-URL: #60250 Refs: #59553 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

It's unlikely that anyone would invest in fixing them on x64 macOS in the near future, now that x64 macOS is being phased out. Simply skip them for now. PR-URL: #60250 Refs: #59553 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

nodejs/node#60250

* chore: bump node in DEPS to v24.11.1 * src: add a default branch for module phase nodejs/node#60261 * src: conditionally disable source phase imports by default nodejs/node#60364 * chore: update patches * src: update locks to use DictionaryTemplate and other minor cleanups nodejs/node#60061 * deps: update simdjson to 4.0.7 nodejs/node#59883 * test: move sea tests into test/sea nodejs/node#60250 * fixup deps: update simdjson to 4.0.7a * src: conditionally disable source phase imports by default nodejs/node#60364 * module: handle null source from async loader hooks in sync hooks nodejs/node#59929 * Revert "src: conditionally disable source phase imports by default" This reverts commit 5f85b84. * src: allow disabling JS source phase imports nodejs/node#60364 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

* chore: bump node in DEPS to v24.11.1 * chore: bump node to v24.11.1 (main) (#48917) * chore: bump node in DEPS to v24.11.1 * src: add a default branch for module phase nodejs/node#60261 * src: conditionally disable source phase imports by default nodejs/node#60364 * chore: update patches * src: update locks to use DictionaryTemplate and other minor cleanups nodejs/node#60061 * deps: update simdjson to 4.0.7 nodejs/node#59883 * test: move sea tests into test/sea nodejs/node#60250 * fixup deps: update simdjson to 4.0.7a * src: conditionally disable source phase imports by default nodejs/node#60364 * module: handle null source from async loader hooks in sync hooks nodejs/node#59929 * Revert "src: conditionally disable source phase imports by default" This reverts commit 5f85b84. * src: allow disabling JS source phase imports nodejs/node#60364 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

This makes skipping/running these tests easier to manage with a dedicated test runner that can be tweaked for SEA. PR-URL: #60250 Refs: #59553 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

It's unlikely that anyone would invest in fixing them on x64 macOS in the near future, now that x64 macOS is being phased out. Simply skip them for now. PR-URL: #60250 Refs: #59553 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

This makes skipping/running these tests easier to manage with a dedicated test runner that can be tweaked for SEA. PR-URL: #60250 Refs: #59553 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

It's unlikely that anyone would invest in fixing them on x64 macOS in the near future, now that x64 macOS is being phased out. Simply skip them for now. PR-URL: #60250 Refs: #59553 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

nodejs/node#60250 (cherry picked from commit 695929b)

* chore: bump node in DEPS to v22.22.1 * chore: update patches * chore: fixup remove_obsolete_noarraybufferzerofillscope.patch * deps: update simdjson to 4.2.4 nodejs/node#61056 * fix: generate_config_gypi needs to generate valid JSON https: //github.com/nodejs/node/pull/60794 (cherry picked from commit a1d06cd) Co-Authored-By: Shelley Vohr <shelley.vohr@gmail.com> * src: fix off-thread cert loading in bundled cert mode nodejs/node#60764 (cherry picked from commit cb4deec) This test fails on boringssl incompatibilities: https://github.com/electron/electron/pull/49744/changes#r2799802487 Co-Authored-By: Shelley Vohr <shelley.vohr@gmail.com> * test: move sea tests into test/sea nodejs/node#60250 (cherry picked from commit 695929b) * src: fix off-thread cert loading in bundled cert mode nodejs/node#60764 The Node.js cli flag --use-bundled-ca is not supported in Electron --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 13, 2025

richardlau requested changes Oct 13, 2025

View reviewed changes

test/sea/sea.status Show resolved Hide resolved

joyeecheung force-pushed the skip-macos-64 branch 2 times, most recently from 425d75f to 4d84244 Compare October 15, 2025 11:41

richardlau approved these changes Oct 15, 2025

View reviewed changes

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2025

This comment was marked as outdated.

Sign in to view

joyeecheung force-pushed the skip-macos-64 branch from 4d84244 to f14e663 Compare October 15, 2025 11:47

github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Oct 15, 2025

This comment was marked as outdated.

Sign in to view

richardlau approved these changes Oct 15, 2025

View reviewed changes

richardlau added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 15, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2025

UlisesGascon approved these changes Oct 15, 2025

View reviewed changes

anonrig approved these changes Oct 16, 2025

View reviewed changes

RaisinTen approved these changes Oct 16, 2025

View reviewed changes

joyeecheung force-pushed the skip-macos-64 branch from f14e663 to 9e8c753 Compare October 17, 2025 10:53

joyeecheung merged commit 9e8c753 into nodejs:main Oct 17, 2025
19 checks passed

github-actions bot mentioned this pull request Oct 27, 2025

2025-10-28, Version 25.1.0 (Current) #60436

Merged

github-actions bot mentioned this pull request Nov 7, 2025

2025-11-11, Version 24.12.0 'Krypton' (LTS) #60615

Closed

github-actions bot mentioned this pull request Nov 7, 2025

2025-11-11, Version 24.11.1 'Krypton' (LTS) #60622

Merged

jkleinsc added a commit to electron/electron that referenced this pull request Nov 13, 2025

test: move sea tests into test/sea

bdcf4e0

nodejs/node#60250

codebytere pushed a commit to electron/electron that referenced this pull request Nov 14, 2025

test: move sea tests into test/sea

695929b

nodejs/node#60250

sxa mentioned this pull request Dec 18, 2025

test: skip sea tests on riscv64 #61111

Merged

aduh95 mentioned this pull request Feb 22, 2026

V22.22.1 proposal #61947

Merged

jkleinsc added a commit to electron/electron that referenced this pull request Mar 9, 2026

test: move sea tests into test/sea

c0d525b

nodejs/node#60250 (cherry picked from commit 695929b)

	[$system==linux && $arch==ppc64]
	# https://github.com/nodejs/node/issues/59561
	test-single-executable-application: SKIP
	test-single-executable-application-assets: SKIP
	test-single-executable-application-assets-raw: SKIP
	test-single-executable-application-asset-keys-empty: SKIP
	test-single-executable-application-asset-keys: SKIP
	test-single-executable-application-disable-experimental-sea-warning: SKIP
	test-single-executable-application-empty: SKIP
	test-single-executable-application-exec-argv: SKIP
	test-single-executable-application-exec-argv-empty: SKIP
	test-single-executable-application-exec-argv-extension-cli: SKIP
	test-single-executable-application-exec-argv-extension-env: SKIP
	test-single-executable-application-exec-argv-extension-none: SKIP
	test-single-executable-application-inspect-in-sea-flags: SKIP
	test-single-executable-application-inspect: SKIP
	test-single-executable-application-snapshot: SKIP
	test-single-executable-application-snapshot-and-code-cache: SKIP
	test-single-executable-application-snapshot-worker: SKIP
	test-single-executable-application-use-code-cache: SKIP

Uh oh!

Conversation

joyeecheung commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

test: move sea tests into test/sea

test: skip sea tests on x64 macOS

Uh oh!

richardlau left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

joyeecheung commented Oct 15, 2025

Uh oh!

This comment was marked as outdated.

joyeecheung commented Oct 15, 2025

Uh oh!

joyeecheung commented Oct 15, 2025

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Oct 15, 2025

Uh oh!

nodejs-github-bot commented Oct 15, 2025

Uh oh!

nodejs-github-bot commented Oct 15, 2025

Uh oh!

nodejs-github-bot commented Oct 15, 2025

Uh oh!

Uh oh!

joyeecheung commented Oct 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

joyeecheung commented Oct 13, 2025 •

edited

Loading

codecov bot commented Oct 13, 2025 •

edited

Loading