Save encrypted files in binary format#32110
Merged
PVince81 merged 1 commit intonextcloud:masterfrom May 5, 2022
Merged
Conversation
szaimen
added
enhancement
2. developing
plumbeo
force-pushed
the
binary-encoding-4
branch
from
b05c19d to
4ca430a
Compare
CarlSchwan
reviewed
Apr 26, 2022
plumbeo
force-pushed
the
binary-encoding-4
branch
from
ec5af88 to
838dbe9
Compare
Contributor
Author
|
Sorry, I forgot to say that I addressed all the review comments. |
artonge
reviewed
Apr 29, 2022
artonge
approved these changes
May 3, 2022
artonge
requested review from
a team,
PVince81 and
come-nc
and removed request for
a team
Contributor
|
@plumbeo Could you fix the DCO ? Else, it looks good :) I have pinged the server team for additional review. |
come-nc
reviewed
May 3, 2022
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
Apart from a few comments, looks good.
artonge
reviewed
May 4, 2022
Default to the more space-efficient binary encoding for newly encrypted files instead of the traditional base64 encoding, eliminating the 33% overhead. The new option 'encryption.use_legacy_encoding' allows to force the legacy encoding format if needed. Files encoded in the old format remain readable. Based on owncloud/encryption#224 and owncloud/core#38249 by karakayasemi. Signed-off-by: plumbeo <plumbeo@users.noreply.github.com>
Member
|
Tests:
|
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Contributor
|
Thanks a lot for the great work @plumbeo !!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22156
Based, with modifications and adjustments where the code diverged, on owncloud/encryption#224 and
owncloud/core#38249.
Tested without seeing obvious problems on master with legacy encoding off and on and on a newly deployed 23.0.4 instance with encryption enabled and a few files uploaded beforehand to simulate an upgrade.
I fixed the existing unit tests that failed but didn’t add new ones to specifically exercise the new and the old format.