Make it possible to filter by tags with REPORT method#1796
Merged
LukasReschke merged 1 commit intomasterfrom Oct 20, 2016
Merged
Make it possible to filter by tags with REPORT method#1796LukasReschke merged 1 commit intomasterfrom
LukasReschke merged 1 commit intomasterfrom
Conversation
Enhanced the REPORT method on the Webdav endpoint and added a "oc:favorite" filter rule. When set, it will return a flat list of results filtered with only favorite files. The web UI was also adjusted to use this REPORT method instead of the private API endpoint. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
|
@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @PVince81 and @nickvergessen to be potential reviewers. |
Member
|
Iirc favorites are just a system tag, wouldn't it be possible to reuse that filtering system |
Member
Author
|
@icewind1991 correct. But maybe do that seperatly from this port. |
Member
|
No favorites are not system tags but the personal tags. otherwise favorites would be shared. |
Member
|
Tested and works 👍 @nickvergessen @LukasReschke Could this get reviewed? It blocks https://github.com/owncloud/core/pull/26186/files to be downstreamed ;) |
Member
|
World didn't explode 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From owncloud/core#26099
Enhanced the REPORT method on the Webdav endpoint and added a
"oc:favorite" filter rule. When set, it will return a flat list of
results filtered with only favorite files.
The web UI was also adjusted to use this REPORT method instead of the
private API endpoint.
CC: @nickvergessen @MorrisJobke @icewind1991 @LukasReschke
Test steps: