Fix mget function signature in WASM binding#1951
Merged
nesbox merged 1 commit intonesbox:mainfrom Jun 7, 2022
Merged
Conversation
nesbox
approved these changes
Jun 7, 2022
nesbox
added a commit
that referenced
this pull request
Jun 7, 2022
Fix mget function signature in WASM binding
nesbox
added a commit
that referenced
this pull request
Jun 7, 2022
Fix mget function signature in WASM binding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WASM function bindings incorrectly attempt to link
mgetas a function with no return type. This causes a "function signature mismatch" error when attempting to run carts that usemget. Both of the current templates (D, Zig) have the correct function signature, so I've just updated thelinkTicAPIfunction to match.