Optimize tic api call performance in LUA.#1628
Merged
nesbox merged 1 commit intonesbox:masterfrom Nov 1, 2021
Merged
Conversation
vsariola
force-pushed
the
feat/core-closure
branch
from
3514e3d to
92ec2f7
Compare
Previously, the tic_core* was associated with a global variable named "_TIC80" and every api call fetches the tic_core by finding the global with this name. Finding the global variable with that name took surprising amount of time, according to profiling. With this optimization, each API function is associated with tic_core* through lua_pushcclosure mechanism. Closures are functions that are associated with certain "upvalues". Fetching an upvalue is very fast in LUA. checkForceExit still fetches the tic_core from the global, as the hook is an ordinary function, not a global.
vsariola
force-pushed
the
feat/core-closure
branch
from
92ec2f7 to
3b4331b
Compare
nesbox
approved these changes
Nov 1, 2021
Owner
nesbox
left a comment
nesbox
left a comment
There was a problem hiding this comment.
Yes, it works faster now.
Thank you for the help.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the tic_core* was associated with a global variable named "_TIC80". Finding the global variable with that name took surprising amount of time, according to profiling. With this optimization, each API function is associated with tic_core* through lua_pushcclosure mechanism. Closures are functions that are associated with certain "upvalues". Fetching an upvalue is very fast in LUA.