X Tutup
Skip to content

Unmap() more netip.Addr vars created from slices#51587

Merged
robmry merged 2 commits intomoby:masterfrom
robmry:unmap_ipv6_addr
Nov 25, 2025
Merged

Unmap() more netip.Addr vars created from slices#51587
robmry merged 2 commits intomoby:masterfrom
robmry:unmap_ipv6_addr

Conversation

@robmry
Copy link
Contributor

@robmry robmry commented Nov 24, 2025 •
edited
Loading

- What I did

In 29.x for Windows containers, with the default binding address 0.0.0.0, the port mapping reported by inspect showed up as ::ffff:0.0.0.0. For example ...

> docker ps
CONTAINER ID   IMAGE       COMMAND   CREATED         STATUS         PORTS                           NAMES
212a8af4131d   busybox80   "sh"      5 seconds ago   Up 3 seconds   [::ffff:0.0.0.0]:8080->80/tcp   c1

- How I did it

  • The first commit fixes the specific issue.
  • The second commit adds more Unmap calls, any/all of which may be unnecessary.
    • (I just did a trawl for calls to netip.AddrFromSlice that didn't have an obvious Unmap.)

- How to verify it

Run docker inspect/ps against a Windows container with published ports.

(Needs an integration test.)

- Human readable description for the release notes

- Windows containers: don't display an IPv6-mapped IPv4 address in port mappings. For example, `[::ffff:0.0.0.0]:8080->80/tcp` instead of `0.0.0.0:8080->80/tcp`.

@robmry
inspect: unmap IPv6-mapped IPv4 host address
2effc1b 
Signed-off-by: Rob Murray <rob.murray@docker.com>
@robmry
Unmap more netip.Addr vars created using AddrFromSlice
a2de9bb 
Signed-off-by: Rob Murray <rob.murray@docker.com>
@robmry robmry added this to the 29.1.0 milestone Nov 24, 2025
@robmry robmry marked this pull request as ready for review November 25, 2025 09:30
@robmry robmry requested a review from akerouanton November 25, 2025 09:30
@robmry robmry requested a review from corhere November 25, 2025 12:20
@robmry
Copy link
Contributor Author

robmry commented Nov 25, 2025

This test seems particularly flaky at the moment. It's unrelated though - I'll merge ...

=== FAIL: amd64.docker.docker.integration.networking TestBridgeICC/IPv6_ULA_on_internal_network (4.59s)
    firewall.go:69: Firewalld reload completed at 2025-11-25T09:47:03Z
    bridge_linux_test.go:218: assertion failed: 1 (res.ExitCode int) != 0 (int)
    bridge_linux_test.go:220: assertion failed: string "PING ctr-icc-3-1 (fdf1:a844:380c:b247::2): 56 data bytes\n\n--- ctr-icc-3-1 ping statistics ---\n1 packets transmitted, 0 packets received, 100% packet loss\n" does not contain "1 packets transmitted, 1 packets received"
    --- FAIL: TestBridgeICC/IPv6_ULA_on_internal_network (4.59s)

@robmry robmry merged commit 18d2a08 into moby:master Nov 25, 2025
276 of 278 checks passed
@robmry robmry deleted the unmap_ipv6_addr branch November 26, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corhere corhere corhere approved these changes

@akerouanton akerouanton akerouanton approved these changes

Assignees

No one assigned

Labels

area/daemon Core Engine area/networking/portmapping Networking area/networking Networking area/rootless Rootless Mode impact/changelog kind/bugfix PR's that fix bugs platform/windows

Projects

None yet

Milestone

29.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@robmry @corhere @akerouanton @vvoland
X Tutup