X Tutup
Skip to content

Add a setting to control whether to enable async jdwp#1208

Merged
testforstephen merged 4 commits intomicrosoft:mainfrom
testforstephen:jinbo_async
Aug 31, 2022
Merged

Add a setting to control whether to enable async jdwp#1208
testforstephen merged 4 commits intomicrosoft:mainfrom
testforstephen:jinbo_async

Conversation

@testforstephen
Copy link
Contributor

@testforstephen testforstephen commented Aug 30, 2022

This PR relates to microsoft/java-debug#436

java.debug.settings.jdwp.async: Experimental: Controls whether the debugger is allowed to send JDWP commands asynchronously. Async mode can improve remote debugging response speed on high-latency networks. Defaults to auto, and automatically enable async mode in VS Code - Insiders.

  • auto (Default)
  • on
  • off

@Eskibear
Copy link
Member

Will this setting appear on settings page for vscode stable editions? If so, shall we explicitly note "for Insiders only" also in this setting's description instead of "experimental" to avoid confusion? Because for stable vscode, I also see some native "experimental" settings that works.

@testforstephen
Copy link
Contributor Author

Will this setting appear on settings page for vscode stable editions? If so, shall we explicitly note "for Insiders only" also in this setting's description instead of "experimental" to avoid confusion? Because for stable vscode, I also see some native "experimental" settings that works.

This is not for Insiders only, just enable it on Insiders by default. For stable, you still can manually opt in.

@Eskibear
Copy link
Member

This is not for Insiders only, just enable it on Insiders by default. For stable, you still can manually opt in.

Sorry for misunderstanding. Then it looks good to me.

@testforstephen testforstephen merged commit 344022b into microsoft:main Aug 31, 2022
@testforstephen testforstephen deleted the jinbo_async branch August 31, 2022 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup