Supports ESLint v8.#1317
Merged
dbaeumer merged 3 commits intomicrosoft:mainfrom Aug 23, 2021
ota-meshi:eslint-v8
Merged
Conversation
Member
|
@ota-meshi thanks a lot for the PR. Will have a look this week. Saw that the first eslint 8.0.0 beta got released lately. |
dbaeumer
requested changes
Aug 20, 2021
Member
dbaeumer
left a comment
dbaeumer
left a comment
There was a problem hiding this comment.
Great work. I would suggest we do the minor word tweak.
Then I will publish an new internal version of the plugin so that users can do some insider testing before we release a new version. Is this OK for you?
server/src/eslintServer.ts
Outdated
| } else if (library.CLIEngine === undefined) { | ||
| } else if (library.CLIEngine === undefined && library.ESLint === undefined) { | ||
| settings.validate = Validate.off; | ||
| connection.console.error(`The eslint library loaded from ${libraryPath} doesn\'t export a CLIEngine. You need at least eslint@1.0.0`); |
Member
There was a problem hiding this comment.
Should we also mention ESLint class. Something like neither exports a CLIEngine nor an ESLint class
Contributor
Author
|
Thank you for the review! I changed the message.
It's OK with me! |
dbaeumer
approved these changes
Aug 23, 2021
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supports ESLint v8.
Specifically, change it to use the
ESLintclass instead of the removedCLIEngine.However, for backward compatibility, if
CLIEngineis present, useCLIEngine. SeeESLintClassEmulatorclass.I checked that this change works by making sure that the marker appears in each of the environments where
eslint@8.0.0-beta.0,eslint@7.32.0, andeslint@6.8.0are installed.