Fix search editor scrolled to bottom on first search when editor group changed.#134693
Merged
JacksonKearl merged 2 commits intomicrosoft:mainfrom Oct 26, 2021
Merged
Fix search editor scrolled to bottom on first search when editor group changed.#134693JacksonKearl merged 2 commits intomicrosoft:mainfrom
JacksonKearl merged 2 commits intomicrosoft:mainfrom
Conversation
Contributor
|
Thanks! Looking into this it seems the real culprit was failing to await the write of the results to the model before setting the view's scroll position, which meant when the contents did come in it tried to insert them "before" the existing scroll position, resulting in the document scrolling to the bottom. It's not clear to me why this only affected editors after they've been moved, perhaps something to do with the view state being stored on a per-group basis. |
Contributor
Author
|
Thanks. That's a much cleaner solution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #134686
I'm not sure it's the best solution, but this solves it.