X Tutup
Skip to content

Expand sheet string#2111

Merged
nodes11 merged 2 commits intomicrosoft:mainfrom
nodes11:expand_sheet_string
Dec 30, 2024
Merged

Expand sheet string#2111
nodes11 merged 2 commits intomicrosoft:mainfrom
nodes11:expand_sheet_string

Conversation

@nodes11
Copy link
Contributor

@nodes11 nodes11 commented Dec 30, 2024

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

We have an internal request to use a more verbose string for the bottom sheet controller resizing handle accessibility label so that the user knows what is being expanded or collapsed.

Previously, the accessibility label would just read "Expand" or "Collapse". Now the accessibility label will read "Expand Sheet" or "Collapse Sheet".

Binary change

(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)

Verification

  • On iPhone, validated that new strings are used when VoiceOver is ON.
  • Using simulator and Accessibility Inspector, validated that the accessibility label is set as expected.
Visual Verification
Before After

|
Screenshot 2024-12-30 at 9 09 09 AM
|
Screenshot 2024-12-30 at 9 09 27 AM
|

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@nodes11 nodes11 requested a review from a team as a code owner December 30, 2024 17:30
@nodes11 nodes11 merged commit 33e8f2e into microsoft:main Dec 30, 2024
@joannaquu joannaquu mentioned this pull request Apr 4, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup