Simplify PR template, introduce MD linter#3051
Merged
HarHarLinks merged 20 commits intomainfrom Dec 9, 2025
Merged
Conversation
HarHarLinks
added
the
meta
Collaborator
Author
|
Linter CI fails expectedly since I didn't dare touch the unlinkified email in the COC. Annotations seem to work, which I think is nice? But iiuc, linter also fails beyond that, i.e. it appears to be ignoring the .rumdl.toml? I have opened this issue about it: rvben/rumdl#185 |
Deploying matrix-website with
|
| Latest commit: |
bcecaef
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ee477955.matrix-website.pages.dev |
| Branch Preview URL: | https://harharlinks-simplify-pr-temp.matrix-website.pages.dev |
HarHarLinks
force-pushed
the
HarHarLinks/simplify-pr-template
branch
3 times, most recently
from
594d643 to
7401b1f
Compare
Contributor
thibaultamartin
left a comment
thibaultamartin
left a comment
There was a problem hiding this comment.
Thanks for the PR, that's going to make reviews much easier!
I've left a few comments for your consideration, mostly:
- Shorten the comments in the PR template categories, and make them more approachable, so people don't imagine they need a super strict reply
- Comment on pinning the rumdl version given the release frequency
- Add comments regarding why we need some permissions in the CI
- Add nice to have rules to consider for a further PR
- Remove unneeded comments to keep the linter config lean
Note: I didn't review each correction in the older blog posts, but if the linter is happy then I am happy. I don't think there would be too much value for us as a WG in spending a lot of time manually reviewing old posts.
If that's a blocker, I would just exclude all the pre-2025 content so we can use the linter for reasonably current and upcoming content.
10 tasks
HarHarLinks
force-pushed
the
HarHarLinks/simplify-pr-template
branch
from
bb87ecb to
1067a9f
Compare
Signed-off-by: Kim Brose <2803622+HarHarLinks@users.noreply.github.com>
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
…close Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
Co-authored-by: Thibault Martin <thibaultamartin@users.noreply.github.com> Signed-off-by: Kim Brose <2803622+HarHarLinks@users.noreply.github.com>
Co-authored-by: Thibault Martin <thibaultamartin@users.noreply.github.com> Signed-off-by: Kim Brose <2803622+HarHarLinks@users.noreply.github.com>
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
HarHarLinks
force-pushed
the
HarHarLinks/simplify-pr-template
branch
from
65a6dcf to
967a5ef
Compare
10 tasks
Signed-off-by: HarHarLinks <2803622+HarHarLinks@users.noreply.github.com>
thibaultamartin
approved these changes
Dec 9, 2025
Contributor
thibaultamartin
left a comment
thibaultamartin
left a comment
There was a problem hiding this comment.
Linter happy, Thib happy
HarHarLinks
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Converts the huge checklist to an easy to fill template and some linter rules.
All steps reviewable commit-by-commit. "Linter commits" have been painstakingly reviewed by human eye and tweaked by human hand.
Related issues
Resolves #3034
Role
🎩 Website & Content WG
Timeline
Signoff
Please sign off your individual commits or whole pull request.