MSC4427: Custom banners for user profiles#4427
MSC4427: Custom banners for user profiles#4427cyrneko wants to merge 4 commits intomatrix-org:mainfrom
Conversation
cyrneko
changed the title
turt2live
added
proposal
There was a problem hiding this comment.
Implementation requirements:
- Client (sending)
- Client (rendering)
There was a problem hiding this comment.
Question, for an implementation to be valid...can it be one that is compatible but uses a different field?
I've just found out that Commet apparently implements this, with the same semantics, however uses chat.commet.profile_banner instead of eu.cyrneko.msc4427.banner / m.banner
I assume not, but I thought I'd ask just in case
There was a problem hiding this comment.
I've pushed a commit that makes the unstable prefix chat.commet.profile_banner
This means there is now two known implementations for this feature:
respective commits:
- Commet: commetchat/commet@95b69ff
- Sable: 7w1/sable@e4f5087
Both of these can set a banner as well as display it on profiles.
There was a problem hiding this comment.
Question, for an implementation to be valid...can it be one that is compatible but uses a different field?
Sure, as long as the spec your describing in this MSC matches an implementation it's valid. The reason for this check is to ensure that the proposal works and the field names do not need to align for that.
And there is precedence for using a existing field name as a unstable key 👍
from `eu.cyrneko.msc4427.banner_url` to `chat.commet.profile_banner`
|
|
||
| Clients can then use this field to load user banners. | ||
|
|
||
| ## Potential issues |
There was a problem hiding this comment.
Would we benefit from a recommendation for the banner dimensions or is this something you'd expect to work itself out organically across clients and users?
There was a problem hiding this comment.
I think this will probably end up being an implementation detail, though I feel guidelines around aspect ratio would make sense probably? Something along the lines of perhaps 1:√21 or another aspect ratio
Footnotes
-
okay, I admit, that's me being a nerd for DIN standard paper sizes. There isn't really necessarily a reason I suggest this ratio in particular ↩
There was a problem hiding this comment.
I can see the point on both to be honest. Mandating an aspect ratio is almost certainly going to be impossible, as clients require their own agency about how to display the banner.
That said, perhaps some wording that banners should be landscale an approximately 3:1 (clients MAY use techniques such as letterboxing or scaling if a banner doesn't fit)
There was a problem hiding this comment.
that sounds good! I'll add that to the doc
if I don't forget at least...
There was a problem hiding this comment.
I did, indeed, forget!
I'll set a reminder with a link to this...
5 participants
Rendered
Signed-off-by: Alexia cyrus42@disroot.org