X Tutup
Skip to content

MSC4341: Support for RFC 8628 Device Authorization Grant#4341

Merged
turt2live merged 9 commits intomainfrom
hughns/device-authorization-grant
Feb 23, 2026
Merged

MSC4341: Support for RFC 8628 Device Authorization Grant#4341
turt2live merged 9 commits intomainfrom
hughns/device-authorization-grant

Conversation

@hughns
Copy link
Member

@hughns hughns commented Sep 3, 2025

Rendered

This was originally part of MSC4108 but has been split out to make review easier and is useful in its own right.

Implementations:


SCT Stuff:

MSC checklist

FCP tickyboxes

@hughns hughns changed the title OAuth 2.0 Device Authorization Grant MSC4341: OAuth 2.0 Device Authorization Grant Sep 3, 2025
@hughns hughns changed the title MSC4341: OAuth 2.0 Device Authorization Grant MSC4341: Support for RFC 8628 Device Authorization Grant Sep 3, 2025
@hughns hughns requested a review from sandhose September 3, 2025 10:54
@hughns hughns marked this pull request as ready for review September 3, 2025 12:13
@turt2live turt2live added proposal A matrix spec change proposal client-server Client-Server API kind:core MSC which is critical to the protocol's success needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Sep 3, 2025
@ara4n ara4n added the matrix-2.0 Required for Matrix 2.0 label Sep 5, 2025
@github-project-automation github-project-automation bot moved this to Tracking for review in Spec Core Team Workflow Sep 5, 2025
@turt2live turt2live moved this from Tracking for review to Proposed for FCP readiness in Spec Core Team Workflow Sep 17, 2025
@turt2live turt2live removed the matrix-2.0 Required for Matrix 2.0 label Sep 24, 2025
@turt2live
Copy link
Member

turt2live commented Jan 6, 2026

MSCs proposed for Final Comment Period (FCP) should meet the requirements outlined in the checklist prior to being accepted into the spec. This checklist is a bit long, but aims to reduce the number of follow-on MSCs after a feature lands.

SCT members: please check off things you check for, and raise a concern against FCP if the checklist is incomplete. If an item doesn't apply, prefer to check it rather than remove it. Unchecking items is encouraged where applicable.

MSC authors: feel free to ask in a thread on your MSC or in the#matrix-spec:matrix.org room for clarification of any of these points.

  • Are appropriate implementation(s) specified in the MSC’s PR description?
  • Are all MSCs that this MSC depends on already accepted?
  • For each new endpoint that is introduced:
    • Have authentication requirements been specified?
    • Have rate-limiting requirements been specified?
    • Have guest access requirements been specified?
    • Are error responses specified?
      • Does each error case have a specified errcode (e.g. M_FORBIDDEN) and HTTP status code?
        • If a new errcode is introduced, is it clear that it is new?
  • Will the MSC require a new room version, and if so, has that been made clear?
    • Is the reason for a new room version clearly stated? For example, modifying the set of redacted fields changes how event IDs are calculated, thus requiring a new room version.
  • Are backwards-compatibility concerns appropriately addressed?
  • Are the endpoint conventions honoured?
    • Do HTTP endpoints use_underscores_like_this?
    • Will the endpoint return unbounded data? If so, has pagination been considered?
    • If the endpoint utilises pagination, is it consistent with the appendices?
  • An introduction exists and clearly outlines the problem being solved. Ideally, the first paragraph should be understandable by a non-technical audience.
  • All outstanding threads are resolved
    • All feedback is incorporated into the proposal text itself, either as a fix or noted as an alternative
  • While the exact sections do not need to be present, the details implied by the proposal template are covered. Namely:
    • Introduction
    • Proposal text
    • Potential issues
    • Alternatives
    • Dependencies
  • Stable identifiers are used throughout the proposal, except for the unstable prefix section
    • Unstable prefixes consider the awkward accepted-but-not-merged state
    • Chosen unstable prefixes do not pollute any global namespace (use “org.matrix.mscXXXX”, not “org.matrix”).
  • Changes have applicable Sign Off from all authors/editors/contributors
  • There is a dedicated "Security Considerations" section which detail any possible attacks/vulnerabilities this proposal may introduce, even if this is "None.". See RFC3552 for things to think about, but in particular pay attention to the OWASP Top Ten.

@turt2live
Copy link
Member

This looks ready for broader review:

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Jan 6, 2026

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Jan 6, 2026
@turt2live turt2live added 00-weekly-pings Tracking for weekly pings in the SCT office. 00 to make it first in the labels list. and removed needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Jan 6, 2026
@turt2live turt2live moved this from Proposed for FCP readiness to Ready for FCP ticks in Spec Core Team Workflow Jan 6, 2026
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
@mscbot
Copy link
Collaborator

mscbot commented Feb 18, 2026

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Feb 18, 2026
@turt2live turt2live removed the 00-weekly-pings Tracking for weekly pings in the SCT office. 00 to make it first in the labels list. label Feb 18, 2026
@turt2live turt2live moved this from Ready for FCP ticks to In FCP in Spec Core Team Workflow Feb 18, 2026
@mscbot
Copy link
Collaborator

mscbot commented Feb 23, 2026

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Feb 23, 2026
@hughns
Copy link
Member Author

hughns commented Feb 23, 2026

Spec PR: matrix-org/matrix-spec#2320

@turt2live turt2live merged commit 1ac8174 into main Feb 23, 2026
1 check passed
@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed finished-final-comment-period labels Feb 23, 2026
@turt2live turt2live moved this from In FCP to Requires spec PR review in Spec Core Team Workflow Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client-server Client-Server API kind:core MSC which is critical to the protocol's success proposal A matrix spec change proposal spec-pr-in-review A proposal which has been PR'd against the spec and is in review

Projects

Status: Requires spec PR review

Development

Successfully merging this pull request may close these issues.

7 participants

X Tutup