Fix marker fillstyle rotation when updating fillstyle in Line2D#31265
Open
jayaprajapatii wants to merge 1 commit intomatplotlib:mainfrom
Open
Fix marker fillstyle rotation when updating fillstyle in Line2D#31265jayaprajapatii wants to merge 1 commit intomatplotlib:mainfrom
jayaprajapatii wants to merge 1 commit intomatplotlib:mainfrom
Conversation
jayaprajapatii
force-pushed
the
fix-marker-fillstyle-rotation
branch
from
a5bc16f to
80cd63d
Compare
Contributor
|
While this maybe works (I didn't check), this will likely not fix the same issue with e.g. marker capstyles and joinstyles. A more general fix seems appropriate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31257
Description
Calling
Line2D.set_fillstyle()recreated theMarkerStyleobject without preserving the existing user transform. As a result, markers that had a rotation transform applied lost their rotation when the fillstyle was updated.This patch recreates the
MarkerStylewith the requested fillstyle while preserving the existing_user_transform, ensuring that rotated markers retain their orientation.Testing