X Tutup
Skip to content

ci: Try pinning an older Python#31152

Closed
QuLogic wants to merge 1 commit intomatplotlib:mainfrom
QuLogic:test-old-python
Closed

ci: Try pinning an older Python#31152
QuLogic wants to merge 1 commit intomatplotlib:mainfrom
QuLogic:test-old-python

Conversation

@QuLogic
Copy link
Member

@QuLogic QuLogic commented Feb 13, 2026

PR summary

Both 3.13.12 and 3.14.3 were released about 10 days ago, but they do take a little while to get through to CI. Trying out an old version to see if it might help with the newish failures.

PR checklist

@QuLogic
Copy link
Member Author

QuLogic commented Feb 13, 2026

Looks like that worked! I can also reproduce the problem (at least for test_norm_callback) locally with an update of Python 3.13.11 to 3.13.12.

I don't have a dev-Python setup, but I think @tacaswell does; maybe you can run a bisect there?

@QuLogic
Copy link
Member Author

QuLogic commented Feb 13, 2026

A quick perusal through the changelog suggests:

gh-142651: unittest.mock: fix a thread safety issue where Mock.call_count may return inaccurate values when the mock is called concurrently from multiple threads.

which was applied to both 3.14.3 and 3.13.12.

A comment there suggests that we should not be modifying call_count ourselves, but instead using reset_mock.

@QuLogic
Copy link
Member Author

QuLogic commented Feb 13, 2026

Also note that Azure had the same problem, since I didn't change that build. Surprisingly no timeouts involved though.

Closing in favour of #31153; this was enough to point me in the right direction.

@QuLogic QuLogic closed this Feb 13, 2026
@QuLogic QuLogic deleted the test-old-python branch March 7, 2026 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

X Tutup