BUG: Fix text appearing far outside valid axis scale range by scottshambaugh · Pull Request #31061 · matplotlib/matplotlib

scottshambaugh · 2026-02-02T23:22:02Z

PR summary

Text didn't have a get_tightbbox override yet, so this adds that with some handling for no-show cases. The _in_axes_domain check is not exclusive to text and may be useful elsewhere, so was given to Artist more broadly.

The plot in the original issue renders correctly now, and I can confirm it was broken for me before:

import matplotlib.pyplot as plt
import numpy as np

x = np.linspace(0, 10, 100)
y = np.sin(x) * 10

fig, ax = plt.subplots()
ax.plot(x, y)
ax.set_yscale('log')
ax.text(5, -5, "I am at y = -5", color='red')

plt.savefig("test_gh31054.png", bbox_inches='tight')

PR checklist

"closes #0000" is in the body of the PR description to link the related issue
new and changed code is tested
[n/a] Plotting related features are demonstrated in an example
[n/a] New Features and API Changes are noted with a directive and release note
[n/a] Documentation complies with general and docstring guidelines

scottshambaugh · 2026-02-03T14:55:13Z

lib/matplotlib/text.py

            return bbox

+    def get_tightbbox(self, renderer=None):
+        # Exclude text at data coordinates outside the valid domain of the axes


if not self.get_visible() or self.get_text() == "": return Bbox.null()

I had originally included these lines, but they were changing a half dozen baseline images as plots expanded to fill space where there was empty/invisible text. Removed for now, but I think that's probably the right behavior and we can discuss including it.

If you think that might be important, you can target that change to the text-overhaul branch.

Do you mean this PR or just that change?

The additional change, unless it's easier for you to do the whole PR.

Sure, I'll wait for this one to merge to avoid the def get_tightbbox conflict

lib/matplotlib/artist.py

timhoffm · 2026-02-08T14:35:49Z

Waiting on #30161. Per #31061 (comment)

scottshambaugh · 2026-02-10T20:28:44Z

This one can merge as-is, then the change discussed above that would regenerate baseline images would be in a separate PR that targets #30161.

lib/matplotlib/text.py

timhoffm · 2026-02-11T08:37:23Z

lib/matplotlib/artist.py

+            vmin, vmax = axis.limit_range_for_scale(val, val)
+            if vmin != val or vmax != val:


Should we grow a method Scale.val_in_range(val). This seems like a logically meaningful API. ScaleBase could implement this as a generic fallback via limit_range_for_scale to support existing third-party scales. But specific scales could implement their logic much more efficiently; e.g. LinearScale would just return True, and LogScale would return val > 0`.

If we do this, probably better in a separate PR.

Yeah, I agree with this follow-on

Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>

timhoffm · 2026-02-25T10:25:08Z

lib/matplotlib/artist.py

        """
        return Bbox([[0, 0], [0, 0]])

+    def _outside_axes_domain(self, x, y):


Architectural reconsideration:

As written this is rather an Axes functionality than an Artist functionality.

The only self usage is self.axes, and we needed to explicitly inverted the semantics to _outside_axes_domain to reasonably cover the case of artists that are not attached to axes.

OTOH below we use this only in the context of an axes:

if (self.axes and self.get_transform() == self.axes.transData and self._outside_axes_domain(*self.get_unitless_position())):

So we could turn this into an Axes method

def _point_in_data_domain(self, x, y):

and call it via

if (self.axes and self.get_transform() == self.axes.transData and not self.axes._point_in_data_domain(*self.get_unitless_position())):

I don't think we'd ever have an artist without an axes, but this ownership boundary makes sense. Updated

We do, e.g. fig.text().

lib/matplotlib/axes/_base.py

QuLogic · 2026-03-10T04:00:29Z

lib/matplotlib/axes/_base.py

        self.stale = True
        return txt

+    def _point_in_data_domain(self, x, y):


Is this not going to be used in 3D at some point (i.e., should it be passing in a tuple instead of individual coordinates)?

This isn't currently called in any 3d path, since the rendering pipeline is so different. We might want to use it for something else, but I'm not too worried about future-proofing internal private functions beforehand.

github-actions bot added the topic: text label Feb 2, 2026

scottshambaugh changed the title ~~BIG: Fix text appearing far outside valid axis scale range~~ BUG: Fix text appearing far outside valid axis scale range Feb 2, 2026

scottshambaugh force-pushed the log_text_negative_coord branch from 0d3ef72 to 7ef9295 Compare February 2, 2026 23:26

Fix text appearing outside axis scale range

4ffb8d3

scottshambaugh force-pushed the log_text_negative_coord branch from 7ef9295 to 4ffb8d3 Compare February 3, 2026 00:13

scottshambaugh marked this pull request as ready for review February 3, 2026 00:26

scottshambaugh commented Feb 3, 2026

View reviewed changes

timhoffm reviewed Feb 3, 2026

View reviewed changes

lib/matplotlib/artist.py Outdated Show resolved Hide resolved

scottshambaugh force-pushed the log_text_negative_coord branch from b558152 to 496411d Compare February 3, 2026 16:44

Rename to _outside_axes_domain

20103e7

scottshambaugh force-pushed the log_text_negative_coord branch from 496411d to 20103e7 Compare February 3, 2026 16:51

timhoffm added the status: waiting for other PR label Feb 8, 2026

scottshambaugh removed the status: waiting for other PR label Feb 10, 2026

timhoffm reviewed Feb 11, 2026

View reviewed changes

sanrishi mentioned this pull request Feb 18, 2026

[ENH]: Give control whether twinx() or twiny() overlays the main axis #31122

Open

Update lib/matplotlib/text.py

371fcb2

Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>

timhoffm reviewed Feb 25, 2026

View reviewed changes

Move domain check to axes

d1bd978

github-actions bot added the topic: axes label Feb 25, 2026

timhoffm approved these changes Feb 26, 2026

View reviewed changes

QuLogic reviewed Mar 10, 2026

View reviewed changes

lib/matplotlib/axes/_base.py Outdated Show resolved Hide resolved

Use _axis_map

bb9daee

QuLogic reviewed Mar 10, 2026

View reviewed changes

		vmin, vmax = axis.limit_range_for_scale(val, val)
		if vmin != val or vmax != val:

Uh oh!

Conversation

scottshambaugh commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR summary

PR checklist

Uh oh!

scottshambaugh Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

timhoffm commented Feb 8, 2026

Uh oh!

scottshambaugh commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

timhoffm Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

scottshambaugh commented Feb 2, 2026 •

edited

Loading

scottshambaugh Feb 3, 2026 •

edited

Loading

scottshambaugh commented Feb 10, 2026 •

edited

Loading

timhoffm Feb 25, 2026 •

edited

Loading