ft2font: Extend OS/2 table with new fields#31050
Merged
QuLogic merged 1 commit intomatplotlib:text-overhaulfrom Feb 5, 2026
Merged
ft2font: Extend OS/2 table with new fields#31050QuLogic merged 1 commit intomatplotlib:text-overhaulfrom
QuLogic merged 1 commit intomatplotlib:text-overhaulfrom
Conversation
github-project-automation
bot
moved this to Waiting for other PR
in Font and text overhaul
QuLogic
moved this from Waiting for other PR
to Ready for Review
in Font and text overhaul
anntzer
reviewed
Jan 31, 2026
src/ft2font_wrapper.cpp
Outdated
| "fsFirstCharIndex"_a=t->usFirstCharIndex, | ||
| "fsLastCharIndex"_a=t->usLastCharIndex); | ||
| if (version >= 1) { | ||
| result["ulCodePageRange1"] = t->ulCodePageRange1; |
Contributor
There was a problem hiding this comment.
make this a tuple, similarly to how we deal with ulCharRange just above?
|
Exposing 'sxHeight' would be very handy for rendering of OpenType math fonts (see #31048). Currently, x-height is tried to be read from the pclt table, which is "strongly discouraged" and nonexistent in most modern fonts, and measured otherwise. |
Member
Author
|
Yes, |
QuLogic
force-pushed
the
extend-os2-table
branch
from
2122af1 to
b922b70
Compare
Versions 1, 2, and 5 add additional fields to this struct, which may or may not be useful in the future.
QuLogic
force-pushed
the
extend-os2-table
branch
from
b922b70 to
2aa38ab
Compare
anntzer
approved these changes
Feb 3, 2026
tacaswell
approved these changes
Feb 5, 2026
github-project-automation
bot
moved this from Ready for Review
to Done
in Font and text overhaul
5 tasks
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Mar 2, 2026
Apparently, when adding the additional fields in matplotlib#31050, I never noticed that some of the required fields were not exposed. Also, fix a few typos in the field names.
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Mar 2, 2026
Apparently, when adding the additional fields in matplotlib#31050, I never noticed that some of the required fields were not exposed. Also, fix a few typos in the field names.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Versions 1, 2, and 5 add additional fields to this struct, which may or may not be useful in the future.
PR checklist