Add type hint for fig_kw in subplots#31033
Merged
QuLogic merged 1 commit intomatplotlib:mainfrom Jan 27, 2026
Merged
Conversation
timhoffm
reviewed
Jan 25, 2026
Member
timhoffm
left a comment
timhoffm
left a comment
There was a problem hiding this comment.
Please do this for all overloads.
sanrishi
force-pushed
the
fix/31003-fig-kw-typing
branch
from
99bc9a7 to
009101a
Compare
sanrishi
force-pushed
the
fix/31003-fig-kw-typing
branch
from
009101a to
3f2bc7c
Compare
Member
|
What is this |
QuLogic
changed the title
QuLogic
approved these changes
Jan 27, 2026
andreas16700
added a commit
to andreas16700/matplotlib
that referenced
this pull request
Jan 28, 2026
…fig_kw in subplots
llohse
pushed a commit
to llohse/matplotlib
that referenced
this pull request
Feb 3, 2026
llohse
pushed a commit
to llohse/matplotlib
that referenced
this pull request
Feb 3, 2026
llohse
pushed a commit
to llohse/matplotlib
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Connects to #31003
Description
Adds
Anytype hint to**fig_kwinpyplot.subplots.Rationale
Currently,
fig_kwis untyped. This causesreportUnknownMemberTypeerrors in downstream projects (likepandas-stubs) that attempt to use strict Pyright type checking. Sincefig_kwpasses arbitrary keyword arguments to theFigureconstructor,Anyis the appropriate type annotation here.PR checklist
fig_kwargument insubplots#31003 is in the body of the PR description to link the related issue