X Tutup
Skip to content

DOC: Correct grammatical issues especially on a/an usage#30736

Merged
timhoffm merged 2 commits intomatplotlib:mainfrom
star1327p:grammar-issues
Nov 9, 2025
Merged

DOC: Correct grammatical issues especially on a/an usage#30736
timhoffm merged 2 commits intomatplotlib:mainfrom
star1327p:grammar-issues

Conversation

@star1327p
Copy link
Contributor

PR summary

I searched for patterns such as " a e" and " an t" in the GitHub codebase, because they are most likely to contain grammatical mistakes. Then I manually reviewed which ones needed to be changed. These patterns are not exhaustive, so a few issues of ("a" vs "an") still remain.

This is not a documentation-only PR, because one change is in the print message of pytest.warns.

PR checklist

@rcomer
Copy link
Member

rcomer commented Nov 9, 2025

To change the test, you will also need to change the part of the main code that the test is covering

f"You passed a edgecolor/edgecolors ({orig_edgecolor!r}) "

@star1327p
Copy link
Contributor Author

@rcomer Thank you for the feedback! I have changed the part of main code as well.

@timhoffm timhoffm merged commit 1ab3332 into matplotlib:main Nov 9, 2025
37 of 40 checks passed
@timhoffm timhoffm added this to the v3.11.0 milestone Nov 9, 2025
@timhoffm
Copy link
Member

timhoffm commented Nov 9, 2025

Thanks @star1327p!

andreas16700 added a commit to andreas16700/matplotlib that referenced this pull request Jan 28, 2026
…tions in strings

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup