Added conversion from datetime to float for position and width parameters in violin plots#30508
Closed
hasanrashid wants to merge 9 commits intomatplotlib:mainfrom
Closed
Added conversion from datetime to float for position and width parameters in violin plots#30508hasanrashid wants to merge 9 commits intomatplotlib:mainfrom
hasanrashid wants to merge 9 commits intomatplotlib:mainfrom
Conversation
Member
|
Hi @hasanrashid thank you for your work on this. I found that your example (and the example from #30417 (comment)) do actually work correctly with the |
…ters in violinplot Resolve merge conflict
Contributor
Author
|
Sorry, I think I messed up the last commit. Cleaning it up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This PR intends to close [ENH]: Support using datetimes as positions argument to violin(...) #30417
It should be possible to set the position of a violin plot to be a datetime. Currently, an attempt to do this results in this error message:
TypeError: unsupported operand type(s) for +: 'float' and 'datetime.datetime'The error stems from trying to perform operations between float and datetime if datetime was provided as position arguments.
The proposed solution:
The violinplot tests in test_axes.py were successful
An example that tests both "width" and "positions":
Example:
PR checklist
positionsargument to violin(...) #30417" is in the body of the PR description to link the related issue