Conversation
Only a few changes are needed. Note that make_png returns an absolute path so path joining is not even needed here. Also restore the recently incorrectly removed usage of dpi in generating the png filename. Also drop an unrelated but outdated comment re: background handling, which is obsolete since 8940c66 (look for `if hack: ...`).
|
I just realized that in #30426 I accidentally and wrongly removed the dpi arg when generating the png filename (at https://github.com/matplotlib/matplotlib/pull/30426/files#diff-6a0383194825a76389747fc0b369645f844ddc7fc7f30b300e4413fe40dc4b17L314); I fixed that in this commit as well so this should also be backported to 3.10.6, hence the milestoning (or I can make a separate commit with just that fix, if we want to be really granular...). |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
|
Hmm, maybe only backport the fix? |
…_dvi & make_png. Includes an extra fix from PR matplotlib#30431: Don't drop dpi in png filename generation.
|
OK, I opened #30434 for the backport with the extra fix. (If you want to first merge the automatic PR and add an extra fix commit on top of that, feel free to do so instead, I don't mind either way.) |
4 participants
Only a few changes are needed. Note that make_png returns an absolute path so path joining is not even needed here.
Also drop an unrelated but outdated comment re: background handling,
which is obsolete since 8940c66 (look for
if hack: ...).PR summary
PR checklist