Support standard tickdir control (in/out/inout) in axisartist.#30369
Support standard tickdir control (in/out/inout) in axisartist.#30369anntzer wants to merge 2 commits intomatplotlib:mainfrom
Conversation
github-actions
bot
added
Documentation: examples
anntzer
force-pushed
the
aiot
branch
2 times, most recently
from
a80878e to
6831cb5
Compare
|
Sure, done. |
timhoffm
left a comment
timhoffm
left a comment
There was a problem hiding this comment.
Sorry, I'm a bit nit-picky today, but let's improve on code and docs, when we touch it anyway.
lib/mpl_toolkits/axisartist/tests/test_grid_helper_curvelinear.py
Outdated
Show resolved
Hide resolved
lib/mpl_toolkits/axisartist/tests/test_grid_helper_curvelinear.py
Outdated
Show resolved
Hide resolved
|
No worries, it's good to improve this... |
|
Some refs still need fixing: |
|
Hopefully the missing references are fixed. |
| # Remove this line when this test image is regenerated. | ||
| plt.rcParams['text.kerning_factor'] = 6 | ||
| plt.rcParams.update({ | ||
| "text.kerning_factor": 6, "xtick.direction": "in", "ytick.direction": "in"}) |
There was a problem hiding this comment.
Do you intend that all of these be removed in the text-overhaul branch, as text.kerning_factor will be?
There was a problem hiding this comment.
I pushed a second commit (as usual, without the actual baseline image updates) where I take advantage of the upcoming text-overhaul branch to update the tests as well; now they are a mix of "in", "out", and "inout" (to test a bit everything). Note that there are also other axisartist tests where there is a high tolerance currently set due to partial updates to the axisartist code; likely those could also have their tolerance set to zero again as the baselines will likely need to be regen'd anyways (I didn't touch them, but I can do it if you prefer -- it's just a grep for tol in the test suite of axisartist).
Let me know if you want me to retarget this to text-overhaul.
... and also respect rcParams, which makes axisartist ticks default to
pointing outwards, similarly to standard ticks.
Rework the tick direction machinery to also support "inout" (similarly
to standard ticks).
One may wonder whether external ticks should really be drawn in the
local direction of the gridlines, though, or whether drawing them
orthogonal to the axis spine would look better. This PR keeps the old
behavior of `set_ticks_out(True)`, but we could later add something like
``set_tick_direction("out_ortho")`` (name up to bikeshedding).
While at it, also deprecate the entirely unused
`Ticks.locs_angles_labels` and `LabelBase.locs_angles_labels`.
3 participants
... and also respect rcParams, which makes axisartist ticks default to pointing outwards, similarly to standard ticks.
Rework the tick direction machinery to also support "inout" (similarly to standard ticks).
One may wonder whether external ticks should really be drawn in the local direction of the gridlines, though, or whether drawing them orthogonal to the axis spine would look better. This PR keeps the old behavior of
set_ticks_out(True), but we could later add something likeset_tick_direction("out_ortho")(name up to bikeshedding).While at it, also deprecate the entirely unused
Ticks.locs_angles_labelsandLabelBase.locs_angles_labels.See the modified simple_axis_pad example:
and demo_curvelinear grid shows why "out_ortho" may actually be a better option:
PR summary
PR checklist