Upgrade to Visual Studio 2022 in appveyor.yml#30239
Merged
QuLogic merged 1 commit intomatplotlib:mainfrom Jul 3, 2025
Merged
Conversation
timhoffm
approved these changes
Jul 1, 2025
QuLogic
requested changes
Jul 3, 2025
Member
QuLogic
left a comment
There was a problem hiding this comment.
Something else is wrong here. AppVeyor uses our conda environment.yml, which as of #28352 includes compilers from conda-forge.
Looking at the diff between logs, conda-forge updated c-compiler/cxx-compiler from 1.9.0 to 1.10.0, and vs2019_win-64 to vs2022_win-64. From https://www.appveyor.com/docs/windows-images-software/ MSVC 2022 is in the "Visual Studio 2022" image, so we either need to pin the compilers from conda-forge, or update to that instead of our current "Visual Studio 2019".
Since we don't use these builds for wheels or anything user-facing like that, I think we should do the latter.
QuLogic
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's see if this resolves the build error
Previous description:
Call vcvars batch file in appveyor.yml
As per https://www.appveyor.com/docs/lang/cpp/
Recent Appveyor builds including #30232 and #30236 are failing with
log lines for
pip install -v --no-build-isolation --editable .[dev]This build at least gets past that command.