Merged
Conversation
timhoffm
reviewed
Jul 1, 2025
Member
timhoffm
left a comment
timhoffm
left a comment
There was a problem hiding this comment.
I've not analyzed the details, but is _check_1d compatible with unit hanling? hlines/vlines do _proces_unit_info as their first task.
Member
Author
|
I did insert this after |
This also has the side-effect of casting torch Tensors to NumPy arrays, which fixes matplotlib#30216. Since `stem` is made up of `plot` and `[hv]lines` whic already do this cast, this just moves it up one level which prevents doing it twice.
timhoffm
approved these changes
Jul 5, 2025
dstansby
approved these changes
Jul 6, 2025
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jul 6, 2025
dstansby
added a commit
that referenced
this pull request
Jul 6, 2025
…233-on-v3.10.x Backport PR #30233 on branch v3.10.x (Check that stem input is 1D)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This also has the side-effect of casting torch Tensors to NumPy arrays, which fixes #30216. Since
stemis made up ofplotand[hv]lineswhic already do this cast, this just moves it up one level which prevents doing it twice.We don't have any testing with torch directly, so I didn't add any of that sort.
PR checklist