agg: Replace facepair_t with std::optional#30196
Merged
anntzer merged 1 commit intomatplotlib:mainfrom Jul 1, 2025
Merged
Conversation
github-actions
bot
added
backend: agg
and removed
CI: Run cibuildwheel
Member
Author
|
Our macOS deployment target is too old to like |
jkseppan
approved these changes
Jun 21, 2025
timhoffm
reviewed
Jun 21, 2025
Member
timhoffm
left a comment
timhoffm
left a comment
There was a problem hiding this comment.
I would decide on one of the APIs
- use pointer-like syntax
if (face),*face - use explicit syntax
if (face.has_value()),face.value()
but not mix them.
This type seems to cover the intent more clearly than `std::pair<bool, ...>`.
github-actions
bot
removed
the
CI: Run cibuildwheel
Member
Author
|
Well, we can't do |
anntzer
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This type seems to cover the intent more clearly than
std::pair<bool, ...>.PR checklist