Remove ttconv backwards-compatibility code#30145
Merged
QuLogic merged 1 commit intomatplotlib:text-overhaulfrom Jun 19, 2025
Merged
Remove ttconv backwards-compatibility code#30145QuLogic merged 1 commit intomatplotlib:text-overhaulfrom
QuLogic merged 1 commit intomatplotlib:text-overhaulfrom
Conversation
github-project-automation
bot
moved this to Waiting for other PR
in Font and text overhaul
oscargus
reviewed
Jun 5, 2025
oscargus
approved these changes
Jun 5, 2025
Member
oscargus
left a comment
oscargus
left a comment
There was a problem hiding this comment.
Minor thing that can be skipped to save CI, but other than that seems fine.
QuLogic
moved this from Waiting for other PR
to Ready for Review
in Font and text overhaul
tacaswell
approved these changes
Jun 19, 2025
Member
|
Please drop the last commit and self-merge. |
github-project-automation
bot
moved this from Ready for Review
to Done
in Font and text overhaul
Member
Author
|
Not going to wait for CI, because it's just going to fail, and then run again when merged, and fail there too... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
When ttconv was replaced by pure Python code, several bits of compatibility code were left in in #18181. This removes those code chunks, as the test images will already be regenerated as part of the larger font work.
As this only affects PDF, and it's only minor rounding/duplicate vertices, the differences are generally only a single pixel for 1 character out of 3 or 4.
PR checklist