FIX: fix submerged margins algorithm being applied twice#30089
Merged
rcomer merged 1 commit intomatplotlib:mainfrom May 25, 2025
Merged
FIX: fix submerged margins algorithm being applied twice#30089rcomer merged 1 commit intomatplotlib:mainfrom
rcomer merged 1 commit intomatplotlib:mainfrom
Conversation
timhoffm
approved these changes
May 20, 2025
rcomer
approved these changes
May 25, 2025
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 25, 2025
…ing applied twice
3 tasks
QuLogic
added a commit
that referenced
this pull request
May 27, 2025
…089-on-v3.10.x Backport PR #30089 on branch v3.10.x (FIX: fix submerged margins algorithm being applied twice)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30076
If a figure had subfigures, the submerged margin algorithm (that tries to deal with margins that are not shared across all axes) would get applied to all axes in the figure, including any that had already been taken care of in a subfigure. This lead to the erroneous behaviour described in #30076.
New version does not apply the algorithm if the axes has already been dealt with in a subfigure.
This PR
now yields:

On main
Test just makes sure that the appropriate subplots are the same height now. The test fails on main.