Closed
Conversation
1 task
Member
|
You would also need to update |
Member
Author
|
As the problem I was trying to solve is solved in a better way to import the relevant things from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
In #30054 there are mypy errors since this private module is not typed and the tests access it directly. I guess there is no harm to have typing here?
Just used mypy stubgen to generate one.
Edit: turns out that stubgen sorts the members in alphabetical order which lead to different enum numbering in the stubfile and the built class, so removed those from the class.
Edit 2: that wasn't it. No idea how to get this (apart from manually order them(?), but that seems brittle...)
PR checklist