Prevent draggable legend from being stuck after scroll event#29270
Closed
Kaustbh wants to merge 1 commit intomatplotlib:mainfrom
Closed
Prevent draggable legend from being stuck after scroll event#29270Kaustbh wants to merge 1 commit intomatplotlib:mainfrom
Kaustbh wants to merge 1 commit intomatplotlib:mainfrom
Conversation
timhoffm
reviewed
Dec 11, 2024
Member
timhoffm
left a comment
timhoffm
left a comment
There was a problem hiding this comment.
This fixes the bug. I have two questions though:
- Why does a scroll_event trigger on_pick? That seems unintuitive to me.
- Are there possibly other events that come into on_pick and need to be escaped as well.
Member
I think we should decide on whether we want that to happen, and if not, stop it earlier in the chain. |
5 tasks
Member
|
Thanks for the PR - I made a slightly different fix in #29842 to solve the issue, so I'll close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #29142
This PR addresses an issue where the draggable legend in Matplotlib becomes stuck to the cursor after a scroll event while hovering over the legend. To "unstick" the legend, users must left-click, which is unintuitive.