FIX: remove __array__ method on BasicUnit#28744
Open
tacaswell wants to merge 3 commits intomatplotlib:mainfrom
Open
FIX: remove __array__ method on BasicUnit#28744tacaswell wants to merge 3 commits intomatplotlib:mainfrom
tacaswell wants to merge 3 commits intomatplotlib:mainfrom
Conversation
The presence of this method causes the numpy float __mul__ to use it in numpy 2.1 which results in the units not being tagged as expected and the example failing.
Member
Author
|
Sorry, I did this a while ago but forgot to actually open the PR! |
timhoffm
approved these changes
Aug 21, 2024
QuLogic
requested changes
Aug 21, 2024
Member
QuLogic
left a comment
QuLogic
left a comment
There was a problem hiding this comment.
This breaks the docs with NumPy 2.0.1.
Member
|
So the bisect points this to numpy/numpy@682cd04 via numpy/numpy#26904. Reading through the array API docs, it seems like setting |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The presence of this method causes the numpy float mul to use it in numpy 2.1 which results in the units not being tagged as expected and the example failing.
PR summary
PR checklist