CI: Add CI to test matplotlib against free-threaded Python#28610
CI: Add CI to test matplotlib against free-threaded Python#28610andfoy wants to merge 8 commits intomatplotlib:mainfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
Tests are passing now! |
|
I do have a slight concern that this has significant copy-paste from the rest of our tests, but I also see an argument that this is easier to deal with than adding conditionals to the existing test ymls. |
|
@tacaswell I 100% agree with your assessment, however, as this new file could disappear once there are proper wheels for all the upstream dependencies (after Python 3.13 release), it can be used to set potential individual tweaks for future free-threaded releases. |
|
@tacaswell I think this PR is ready for review! |
|
Can you please fix the linting issue ? |
| uses: deadsnakes/action@6c8b9b82fe0b4344f4b98f2775fcc395df45e494 # v3.1.0 | ||
| with: | ||
| python-version: "3.13" | ||
| nogil: true |
There was a problem hiding this comment.
| uses: deadsnakes/action@6c8b9b82fe0b4344f4b98f2775fcc395df45e494 # v3.1.0 | |
| with: | |
| python-version: "3.13" | |
| nogil: true | |
| uses: deadsnakes/action@6c8b9b82fe0b4344f4b98f2775fcc395df45e494 # v3.1.0 | |
| with: | |
| python-version: "3.13" | |
| nogil: true |
In addition, the whole file should be dedented by 4 spaces (aside from the first line which has no spaces)
|
Thanks for the PR! I have rolled all these changes into #28689. |
4 participants
PR summary
See #28611
This PR enables testing matplotlib against free-threaded Python, this is part of the ongoing effort to test projects against the changes proposed in PEP703
For more information see the following related PRs in other projects:
PR checklist