Disable clipping in Agg resamplers.#28122
Conversation
|
Wow, this looks like a really nice simplification and should fix some of the high dynamic range issues where we ran into problems around the 0.1/0.9 floating point representation creating incorrect under/over values. Is this waiting on #28061 ? |
|
Apologies for the slow reply, I have basically no time to work on this these days (just a temporary thing). |
|
TBH, I've not followed the relation with #28061, so I'm not clear whether we can just merge or whether we should wait. The change itself is good to go. |
jklymak
left a comment
jklymak
left a comment
There was a problem hiding this comment.
I think this is likely correct and certainly doesn't need to wait on #28061. But maybe @tacaswell should weigh in as the previous method was his.
I chose to add macro guards directly in the agg source as that seemed easier than copy-pasting the whole code. I chose to bump the tolerance on test_rgba_antialias (as that's also getting bumped by the interpolation_stage antialias PR) and to test_pngsuite (which is not particularly relevant), and to update the other baselines.
|
Thank you for getting this done! |
5 participants
I chose to add macro guards directly in the agg source as that seemed easier than copy-pasting the whole code.
I chose to bump the tolerance on test_rgba_antialias (as that's also getting bumped by the interpolation_stage antialias PR) and to test_pngsuite (which is not particularly relevant), and to update the other baselines.
PR summary
PR checklist