X Tutup
Skip to content

Move doc/users/installing/ to doc/install/#27747

Merged
QuLogic merged 9 commits intomatplotlib:mainfrom
shriyakalakata:install_docs
Apr 4, 2024
Merged

Move doc/users/installing/ to doc/install/#27747
QuLogic merged 9 commits intomatplotlib:mainfrom
shriyakalakata:install_docs

Conversation

@shriyakalakata
Copy link
Contributor

@shriyakalakata shriyakalakata commented Feb 5, 2024

PR summary

This PR addresses the issue #27396 on moving non user guide related content out of /users. This is the second step, moving /doc/users/installing -> /doc/install.

PR checklist

@shriyakalakata shriyakalakata marked this pull request as draft February 5, 2024 01:22
@story645
Copy link
Member

story645 commented Mar 13, 2024

Probably gonna need a git grep here, but the following will likely need to be updated:
*

@github-actions github-actions bot added Documentation: devdocs files in doc/devel Documentation: user guide files in galleries/users_explain or doc/users Documentation: API files in lib/ and doc/api labels Mar 13, 2024
@shriyakalakata shriyakalakata mentioned this pull request Mar 14, 2024
Closed
@shriyakalakata shriyakalakata marked this pull request as ready for review March 14, 2024 04:50
@shriyakalakata
Copy link
Contributor Author

shriyakalakata commented Mar 30, 2024

Hey, I'm not sure why two of the tests are failing. I would appreciate some help

@story645
Copy link
Member

story645 commented Apr 1, 2024 •
edited
Loading

@rcomer caught that you probably need to rebase b/c there's been changes to the tests/CI code. The needs-rebase flag didn't get triggered b/c that code doesn't conflict with this PR.

@shriyakalakata
Copy link
Contributor Author

shriyakalakata commented Apr 2, 2024 •
edited
Loading

you probably need to rebase b/c there's been changes to the tests/CI code

@story645 done!

QuLogic
QuLogic reviewed Apr 4, 2024
View reviewed changes
@shriyakalakata @QuLogic
Update doc/install/dependencies.rst
aa9e209 
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@QuLogic QuLogic added this to the v3.9.0 milestone Apr 4, 2024
story645
story645 approved these changes Apr 4, 2024
View reviewed changes
pyproject.toml
[project.urls]
"Homepage" = "https://matplotlib.org"
"Download" = "https://matplotlib.org/stable/users/installing/index.html"
"Download" = "https://matplotlib.org/stable/install/index.html"
Copy link
Member

@story645 story645 Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it ok to change this now or should this wait for the other redirects?

Copy link
Member

@QuLogic QuLogic Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine; it'll only affect the rc page, and once final is out, we'll update the main page to go along with it.

@QuLogic QuLogic merged commit feb2780 into matplotlib:main Apr 4, 2024
@QuLogic
Copy link
Member

QuLogic commented Apr 4, 2024

Oops, I thought of squashing earlier, but didn't; oh well.

@shriyakalakata shriyakalakata deleted the install_docs branch April 4, 2024 21:26
@story645 story645 mentioned this pull request Apr 4, 2024
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuLogic QuLogic QuLogic approved these changes

@story645 story645 story645 approved these changes

Assignees

No one assigned

Labels

Documentation: API files in lib/ and doc/api Documentation: devdocs files in doc/devel Documentation: user guide files in galleries/users_explain or doc/users

Projects

None yet

Milestone

v3.9.0

Development

Successfully merging this pull request may close these issues.

[Doc]: Move non user guide related content out of /users

3 participants

@shriyakalakata @story645 @QuLogic
X Tutup