#26865 removing deprecations to axislines.py#26900
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
farrjere
force-pushed
the
deprecated
branch
3 times, most recently
from
acb4a7f to
5044e8f
Compare
oscargus
left a comment
oscargus
left a comment
There was a problem hiding this comment.
Thanks!
I think this is good, subject to updating the wording of the release note.
farrjere
force-pushed
the
deprecated
branch
from
5044e8f to
0e799a8
Compare
|
For a second reviewer: there is a PR open for patches, #26890, but this can go in as is, the other requires some updates. |
|
We merged another PR that addressed the patches portions of this, @farrjere can you refocus this PR on only the axislines portion? |
lib/matplotlib/patches.pyi
Outdated
| class _Base(ConnectionStyle): | ||
| @ api.deprecated("3.7") | ||
| class SimpleEvent: | ||
| def __init__(self, xy: tuple[float, float]) -> None: ... | ||
| def __init__(self, xy): | ||
| self.x, self.y = xy |
There was a problem hiding this comment.
We do not wish to add this back, especially as this is a pyi stub file (where @api.deprecated has no effect)
ksunden
left a comment
ksunden
left a comment
There was a problem hiding this comment.
Please revert changes to patches.pyi
|
Needs a rebase because an adjacent bit of code was modified (adding a new deprecation for the 3.9 cycle). That deprecation should be kept, but the removal of the |
|
Wouldn't handling the merge conflict handle that? I went to do this myself but it resulted in an issue with _version.py having a formatting issue that couldn't commit (coming from the merge). |
|
Rebasing is our preferred method of handling merge conflicts.
The patch as submitted has additions to |
|
Thanks @farrjere! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
QuLogic
changed the title
4 participants
PR summary
This PR removes the depcrecated code during the version 3.7 from patches.py and axislines.py for the issue #26865
PR checklist