TightLayoutEngine.execute runs get_tight_layout_figure twice#26203
Open
leejjoon wants to merge 1 commit intomatplotlib:mainfrom
Open
TightLayoutEngine.execute runs get_tight_layout_figure twice#26203leejjoon wants to merge 1 commit intomatplotlib:mainfrom
leejjoon wants to merge 1 commit intomatplotlib:mainfrom
Conversation
jklymak
reviewed
Nov 30, 2023
Member
jklymak
left a comment
There was a problem hiding this comment.
This seems like a fine thing to do. Not sure if we want to change that many images.
Member
|
Given that most people should be using constrained_layout nowadys, and that tight_layout has other shortcomings as well, I think that changing the behavior - even if it means improving - is not worth it. Those who are using tight_layout are likely ok with the existing behavior. Those who want a better layout engine should switch to constrained_layout. I therefore propose to close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
If
AutoLocatoris used, changing the location of axes may change the ticklabels.Thus the result of tight_layout may not be optimal.
The PR simply runs the algorithm twice.
ConstrainedLayoutEnginealso runs its algorithm twice (_constrained_layout.do_constrained_layout)PR checklist