Simplest pyproject.toml containing build-system only#24102
Simplest pyproject.toml containing build-system only#24102tacaswell merged 7 commits intomatplotlib:mainfrom
Conversation
|
For C/C++ coverage to work, need a CI build using Edit: The above is no longer true, now if coverage is enabled this PR stores I think we will probably need to use |
ianthomas23
force-pushed
the
simple_pyproject
branch
from
da8b828 to
bdfd2ff
Compare
|
This is now working as expected, and is the smallest set of changes needed to use |
| super().run() | ||
| update_matplotlibrc( | ||
| Path(self.build_lib, "matplotlib/mpl-data/matplotlibrc")) | ||
| if not self.editable_mode: |
There was a problem hiding this comment.
It surprised me to discover that when you build the main branch in editable mode this run function is not called. This branch does call the run function so here I am explicitly avoiding the update_matplotlibrc call when in editable mode to give the same behaviour as main branch.
There was a problem hiding this comment.
Editable (via pip/setuptools) is quite different from a regular build. I'm not an expert there, but have the feeling that if in doubt expectations on editable installs do not hold. Possibly pep660 will change that.
|
Lets get this in ASAP so we can shake out any issues with it. |
4 participants
This is the start of a transition to a
pyproject.tomlbuild system (issue #23815) and is a alternative to (or precursor to) PR #23829.This is the only part of the
pyproject.tomltransition that is required for thepybind11progress to continue. So after this is merged work can continue on bothpyproject.tomlandpybind11independently.