Support non-integer bases in mathtext sqrt#19186
Support non-integer bases in mathtext sqrt#19186timhoffm wants to merge 1 commit intomatplotlib:masterfrom
Conversation
1d71821 to
96a2601
Compare
dopplershift
left a comment
There was a problem hiding this comment.
I’d much rather have the tests. 72kb doesn’t seem worth worrying about.
|
Actually one possibility would be to only test in svg and using In order to render the result correctly, inkscape needs to know the path to Matplotlib fonts. This can either be done by adding "Additional font directories" in the Inkscape GUI under preferences/tools/text, or (I guess that'll be the practical solution for us, which should be reasonably easily automatable) by copying the Matplotlib fonts to e.g. I think the savings may be worth it? Especially as this should allow us to work much more regularly on adding mathtext improvements without being restricted by the baseline images problem at all. |
|
Can we not merge the new tests with the old ones? |
|
Superseded by #19261. |
PR Summary
Fixes #8665 by using the code snippet proposed there #8665 (comment).
The test images show that it works.
I'm a bit hesitant to add 72kB of images just for testing this. I would also be ok to strip the test again and commit without tests. It's rather unlikely that we'll touch the base part of
sqrtagain and break it.