Allow Type3 subsetting of otf fonts in pdf backend.#18651
Merged
timhoffm merged 1 commit intomatplotlib:masterfrom Oct 11, 2020
Merged
Allow Type3 subsetting of otf fonts in pdf backend.#18651timhoffm merged 1 commit intomatplotlib:masterfrom
timhoffm merged 1 commit intomatplotlib:masterfrom
Conversation
QuLogic
approved these changes
Oct 6, 2020
Member
QuLogic
left a comment
QuLogic
left a comment
There was a problem hiding this comment.
I guess a test font file would be too large; the linked issue is fixed. The text cannot be selected though, which seems a slight regression. On the other, it's actually displaying the right character glyphs now.
Contributor
Author
|
See #18517 (review) re: text selection. I think it would be very hard to have that working, and in any case I'd say correct but unselectable glyphs is better than incorrect but selectable glyphs :) |
timhoffm
approved these changes
Oct 11, 2020
This is supported since 19359c1, results in smaller files (*much* smaller when using CJK fonts), and avoids running into issues with type 42 embedding and certain pdf readers such as Acrobat Reader.
Contributor
Author
|
rebased |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is supported since 19359c1, results in smaller files (much
smaller when using CJK fonts), and avoids running into issues with type
42 embedding and certain pdf readers such as Acrobat Reader.
Closes #12636.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).