Support horizontalalignment in TextArea/AnchoredText.#18367
Merged
tacaswell merged 1 commit intomatplotlib:masterfrom Aug 28, 2020
Merged
Support horizontalalignment in TextArea/AnchoredText.#18367tacaswell merged 1 commit intomatplotlib:masterfrom
tacaswell merged 1 commit intomatplotlib:masterfrom
Conversation
jklymak
approved these changes
Aug 28, 2020
dopplershift
requested changes
Aug 28, 2020
Contributor
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
Looks good. Just the minor typo.
QuLogic
force-pushed
the
anchoredtext-align
branch
from
36b7ee7 to
50ec1c6
Compare
dopplershift
approved these changes
Aug 28, 2020
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This turned out to be pretty straightforward, and seems to have not broken anything. We could also do the same thing for vertical alignment, but since multi-line text doesn't flow that way (that I know of), I'm not sure it would have any effect.
Fixes #18363.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).