Avoid usage of unittest.makeSuite, removed from Python 3.13#385
Merged
scoder merged 1 commit intolxml:masterfrom Oct 30, 2023
Merged
Avoid usage of unittest.makeSuite, removed from Python 3.13#385scoder merged 1 commit intolxml:masterfrom
scoder merged 1 commit intolxml:masterfrom
Conversation
Patch generated by:
sed -i 's/unittest.makeSuite/unittest.defaultTestLoader.loadTestsFromTestCase/g' $(grep -rl makeSuite)
Member
|
Thanks. I've already started working on the port, while testing Cython in 3.13. The 3.11 test failures are known. I might consider finally dropping Py2.7 support in the upcoming lxml 5.0. Seems a good time to do it. |
Contributor
Author
|
Anyway, this seems to actually work with 2.7. |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch generated by:
No idea if this will work on Python 2, hence only opening as a draft.