Add inline_style option#180
Merged
scoder merged 2 commits intolxml:masterfrom Jul 24, 2016
chripede:patch-2
Merged
Conversation
Currently the style option will remove both style tags and attributes. This change makes each an option, just like scripts and javascript.
Member
|
This breaks both the API and a test. And it adds a new option without testing it. No way I can accept that. |
Contributor
Author
|
Was in a hurry and forgot the tests. I fixed the broken one and added a new one. |
Member
|
It still breaks the API, though. If you want a new option for such a special case, it shouldn't break all code out there. It should just be a new option. |
Contributor
Author
|
So in order to not break the API, should I move the inline_style into the style and default inline_style to True? |
Member
|
I think they should be separate options where the new one falls back to the old one if not provided. d3b73e5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the style option will remove both style tags and attributes.
This change makes each an option, just like scripts and javascript.