fix: support pytest on python 3.12 wrt Fraction formatting change#1821
Merged
hgrecco merged 1 commit intohgrecco:masterfrom Jul 17, 2023
Merged
fix: support pytest on python 3.12 wrt Fraction formatting change#1821hgrecco merged 1 commit intohgrecco:masterfrom
hgrecco merged 1 commit intohgrecco:masterfrom
Conversation
python 3.12 supports float-style formatting for Fraction by python/cpython#100161 . With this change, when ":n" format specifier is used in format() for Fraction type, this now raises ValueError instead of previous TypeError. To make pytest succeed with python 3.12, make pint.testing.assert_allclose also rescue ValueError . Fixes hgrecco#1818 .
CodSpeed Performance ReportMerging #1821 will not alter performanceComparing Summary
|
Owner
|
Awesome! Thanks a lot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python 3.12 supports float-style formatting for Fraction by python/cpython#100161 .
With this change, when ":n" format specifier is used in format() for Fraction type, this now raises ValueError instead of previous TypeError.
To make pytest succeed with python 3.12, make
pint.testing.assert_allclose also rescue ValueError .
Fixes #1818 .
pre-commit run --all-fileswith no errors