X Tutup
Skip to content

Fix sizing of some maps and collections #4148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbakerman merged 1 commit into from
Oct 23, 2025
Merged

Fix sizing of some maps and collections #4148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/main/java/graphql/execution/ValuesResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package graphql.execution;


import com.google.common.collect.Maps;
import graphql.GraphQLContext;
import graphql.Internal;
import graphql.collect.ImmutableKit;
Expand Down Expand Up @@ -109,7 +110,7 @@ public static NormalizedVariables getNormalizedVariableValues(
Locale locale
) {
GraphqlFieldVisibility fieldVisibility = schema.getCodeRegistry().getFieldVisibility();
Map<String, NormalizedInputValue> result = new LinkedHashMap<>();
Map<String, NormalizedInputValue> result = Maps.newLinkedHashMapWithExpectedSize(variableDefinitions.size());
for (VariableDefinition variableDefinition : variableDefinitions) {
String variableName = variableDefinition.getName();
GraphQLType variableType = TypeFromAST.getTypeFromAST(schema, variableDefinition.getType());
Expand Down Expand Up @@ -330,7 +331,7 @@ private static Map<String, Object> getArgumentValuesImpl(
return ImmutableKit.emptyMap();
}

Map<String, Object> coercedValues = new LinkedHashMap<>();
Map<String, Object> coercedValues = Maps.newLinkedHashMapWithExpectedSize(arguments.size());
Map<String, Argument> argumentMap = argumentMap(arguments);
for (GraphQLArgument argumentDefinition : argumentTypes) {
GraphQLInputType argumentType = argumentDefinition.getType();
Expand Down Expand Up @@ -384,7 +385,7 @@ private static Map<String, Object> getArgumentValuesImpl(
}

private static Map<String, Argument> argumentMap(List<Argument> arguments) {
Map<String, Argument> result = new LinkedHashMap<>(arguments.size());
Map<String, Argument> result = Maps.newLinkedHashMapWithExpectedSize(arguments.size());
for (Argument argument : arguments) {
result.put(argument.getName(), argument);
}
Expand Down Expand Up @@ -463,8 +464,9 @@ private static List<Object> literalToNormalizedValueForList(GraphqlFieldVisibili
Value value,
Map<String, NormalizedInputValue> normalizedVariables) {
if (value instanceof ArrayValue) {
List<Object> result = new ArrayList<>();
for (Value valueInArray : ((ArrayValue) value).getValues()) {
List<Value> values = ((ArrayValue) value).getValues();
List<Object> result = new ArrayList<>(values.size());
for (Value valueInArray : values) {
Object normalisedValue = literalToNormalizedValue(
fieldVisibility,
type.getWrappedType(),
Expand Down
4 changes: 3 additions & 1 deletion src/main/java/graphql/execution/incremental/DeferredExecutionSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableListMultimap;
import com.google.common.collect.ImmutableSet;
import com.google.common.collect.Sets;
import graphql.ExecutionResult;
import graphql.ExecutionResultImpl;
import graphql.Internal;
Expand Down Expand Up @@ -117,7 +118,8 @@ public List<String> getNonDeferredFieldNames(List<String> allFieldNames) {
@Override
public Set<IncrementalCall<? extends IncrementalPayload>> createCalls() {
ImmutableSet<DeferredExecution> deferredExecutions = deferredExecutionToFields.keySet();
Set<IncrementalCall<? extends IncrementalPayload>> set = new HashSet<>(deferredExecutions.size());
Set<IncrementalCall<? extends IncrementalPayload>> set = Sets.newHashSetWithExpectedSize(deferredExecutions.size());

for (DeferredExecution deferredExecution : deferredExecutions) {
set.add(this.createDeferredFragmentCall(deferredExecution));
}
Expand Down
3 changes: 2 additions & 1 deletion src/main/java/graphql/schema/DataLoaderWithContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package graphql.schema;

import com.google.common.collect.Maps;
import graphql.Internal;
import graphql.execution.Async;
import graphql.execution.incremental.AlternativeCallContext;
Expand Down Expand Up @@ -66,7 +67,7 @@ public CompletableFuture<Map<K, V>> loadMany(Map<K, ?> keysAndContexts) {
assertNotNull(keysAndContexts);

CompletableFuture<Map<K, V>> result;
Map<K, CompletableFuture<V>> collect = new HashMap<>(keysAndContexts.size());
Map<K, CompletableFuture<V>> collect = Maps.newHashMapWithExpectedSize(keysAndContexts.size());
for (Map.Entry<K, ?> entry : keysAndContexts.entrySet()) {
K key = entry.getKey();
Object keyContext = entry.getValue();
Expand Down
3 changes: 2 additions & 1 deletion src/main/java/graphql/validation/rules/UniqueVariableNames.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package graphql.validation.rules;

import com.google.common.collect.Sets;
import graphql.Internal;
import graphql.language.OperationDefinition;
import graphql.language.VariableDefinition;
Expand Down Expand Up @@ -32,7 +33,7 @@ public void checkOperationDefinition(OperationDefinition operationDefinition) {
return;
}

Set<String> variableNameList = new LinkedHashSet<>(variableDefinitions.size());
Set<String> variableNameList = Sets.newLinkedHashSetWithExpectedSize(variableDefinitions.size());


for (VariableDefinition variableDefinition : variableDefinitions) {
Expand Down
Loading
X Tutup