X Tutup
Skip to content

chore: Remove unused imports and local variables #3034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbakerman merged 1 commit into from
Nov 30, 2022
Merged

chore: Remove unused imports and local variables #3034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/main/java/graphql/Directives.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,11 @@
package graphql;


import com.google.common.collect.ImmutableSet;
import graphql.language.Description;
import graphql.language.DirectiveDefinition;
import graphql.language.StringValue;
import graphql.schema.GraphQLDirective;

import java.util.Set;

import static graphql.Scalars.GraphQLBoolean;
import static graphql.Scalars.GraphQLString;
import static graphql.introspection.Introspection.DirectiveLocation.ARGUMENT_DEFINITION;
Expand Down
1 change: 0 additions & 1 deletion src/main/java/graphql/ExecutionResultImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import java.util.function.Consumer;

import static graphql.collect.ImmutableKit.map;

Expand Down
1 change: 0 additions & 1 deletion src/main/java/graphql/cachecontrol/CacheControl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import graphql.DeprecatedAt;
import graphql.ExecutionInput;
import graphql.ExecutionResult;
import graphql.ExecutionResultImpl;
import graphql.PublicApi;
import graphql.execution.ResultPath;
import graphql.schema.DataFetchingEnvironment;
Expand Down
2 changes: 0 additions & 2 deletions src/main/java/graphql/execution/AsyncExecutionStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@
import graphql.execution.instrumentation.Instrumentation;
import graphql.execution.instrumentation.parameters.InstrumentationExecutionStrategyParameters;

import java.util.ArrayList;
import java.util.List;
import java.util.Set;
import java.util.concurrent.CompletableFuture;
import java.util.function.BiConsumer;

Expand Down
1 change: 0 additions & 1 deletion src/main/java/graphql/i18n/I18n.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package graphql.i18n;

import graphql.GraphQLContext;
import graphql.Internal;
import graphql.VisibleForTesting;

Expand Down
2 changes: 0 additions & 2 deletions src/main/java/graphql/language/NodeBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
import java.util.List;
import java.util.Map;

import static graphql.Assert.assertNotNull;

@PublicApi
public interface NodeBuilder {

Expand Down
1 change: 0 additions & 1 deletion src/main/java/graphql/language/ObjectTypeExtensionDefinition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import graphql.PublicApi;
import graphql.collect.ImmutableKit;

import java.util.ArrayList;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
Expand Down
1 change: 0 additions & 1 deletion src/main/java/graphql/language/PrettyAstPrinter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package graphql.language;

import graphql.ExperimentalApi;
import graphql.PublicApi;
import graphql.collect.ImmutableKit;
import graphql.parser.CommentParser;
import graphql.parser.NodeToRuleCapturingParser;
Expand Down
1 change: 0 additions & 1 deletion src/main/java/graphql/language/TypeName.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import graphql.util.TraversalControl;
import graphql.util.TraverserContext;

import java.util.ArrayList;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
Expand Down
1 change: 0 additions & 1 deletion src/main/java/graphql/language/VariableReference.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import graphql.util.TraversalControl;
import graphql.util.TraverserContext;

import java.util.ArrayList;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
Expand Down
10 changes: 0 additions & 10 deletions src/main/java/graphql/schema/CodeRegistryVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,6 @@

import graphql.Internal;
import graphql.introspection.Introspection;
import graphql.schema.DataFetcher;
import graphql.schema.FieldCoordinates;
import graphql.schema.GraphQLCodeRegistry;
import graphql.schema.GraphQLFieldDefinition;
import graphql.schema.GraphQLFieldsContainer;
import graphql.schema.GraphQLInterfaceType;
import graphql.schema.GraphQLSchemaElement;
import graphql.schema.GraphQLTypeVisitorStub;
import graphql.schema.GraphQLUnionType;
import graphql.schema.TypeResolver;
import graphql.util.TraversalControl;
import graphql.util.TraverserContext;

Expand Down
1 change: 0 additions & 1 deletion src/main/java/graphql/schema/GraphQLAppliedDirectiveArgument.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import graphql.Assert;
import graphql.GraphQLContext;
import graphql.PublicApi;
import graphql.collect.ImmutableKit;
import graphql.language.Argument;
import graphql.language.Value;
import graphql.util.TraversalControl;
Expand Down
1 change: 0 additions & 1 deletion src/main/java/graphql/schema/diff/DiffCtx.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
import java.util.Deque;
import java.util.List;
import java.util.Optional;
import java.util.Stack;

/*
* A helper class that represents diff state (eg visited types) as well as helpers
Expand Down
6 changes: 2 additions & 4 deletions src/main/java/graphql/schema/diffing/DiffImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.LinkedHashSet;
import java.util.List;
import java.util.Map;
Expand All @@ -19,7 +18,6 @@

import static graphql.Assert.assertTrue;
import static graphql.schema.diffing.EditorialCostForMapping.editorialCostForMapping;
import static java.util.Collections.singletonList;

@Internal
public class DiffImpl {
Expand Down Expand Up @@ -97,7 +95,7 @@ OptimalEdit diffImpl(Mapping startMapping, List<Vertex> relevantSourceList, List
queue.add(firstMappingEntry);
firstMappingEntry.siblingsFinished = true;
// queue.add(new MappingEntry());
int counter = 0;
// int counter = 0;
while (!queue.isEmpty()) {
MappingEntry mappingEntry = queue.poll();
// System.out.println((++counter) + " check entry at level " + mappingEntry.level + " queue size: " + queue.size() + " lower bound " + mappingEntry.lowerBoundCost + " map " + getDebugMap(mappingEntry.partialMapping));
Expand Down Expand Up @@ -136,7 +134,7 @@ private void addChildToQueue(MappingEntry parentEntry,
List<Vertex> sourceList,
List<Vertex> targetList

) throws Exception {
) {
Mapping partialMapping = parentEntry.partialMapping;
int level = parentEntry.level;

Expand Down
3 changes: 1 addition & 2 deletions src/main/java/graphql/schema/diffing/ana/EditOperationAnalyzer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,7 @@ private void handleInputFieldChange(EditOperation editOperation) {
Vertex inputObject = newSchemaGraph.getInputObjectForInputField(inputField);
String oldName = editOperation.getSourceVertex().getName();
String newName = inputObject.getName();
getInputObjectModification(inputObject.getName()).getDetails().add(new InputObjectFieldRename(oldName, inputField.getName()));
getInputObjectModification(newName).getDetails().add(new InputObjectFieldRename(oldName, inputField.getName()));
}

private void handleArgumentChange(EditOperation editOperation) {
Expand Down Expand Up @@ -1068,7 +1068,6 @@ private EditOperation findDeletedEdge(Vertex targetVertexFrom, List<EditOperatio
private void typeEdgeChanged(EditOperation editOperation) {
Edge targetEdge = editOperation.getTargetEdge();
Vertex from = targetEdge.getFrom();
Vertex to = targetEdge.getTo();
if (from.isOfType(SchemaGraph.FIELD)) {
outputFieldTypeChanged(editOperation);
} else if (from.isOfType(SchemaGraph.ARGUMENT)) {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/graphql/schema/idl/SchemaGeneratorHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1094,7 +1094,7 @@ private List<Directive> directivesOf(List<? extends TypeDefinition<?>> typeDefin
private <T extends GraphQLDirectiveContainer> T directivesObserve(BuildContext buildCtx, T directiveContainer) {
if (!buildCtx.directiveWiringRequired) {
boolean requiresWiring = SchemaGeneratorDirectiveHelper.schemaDirectiveWiringIsRequired(directiveContainer, buildCtx.getTypeRegistry(), buildCtx.getWiring());
buildCtx.directiveWiringRequired = buildCtx.directiveWiringRequired | requiresWiring;
buildCtx.directiveWiringRequired = buildCtx.directiveWiringRequired || requiresWiring;
Copy link
Contributor Author

@federicorispo federicorispo Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a typo

Copy link
Member

@bbakerman bbakerman Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed

}
return directiveContainer;
}
Expand Down
2 changes: 0 additions & 2 deletions src/main/java/graphql/schema/impl/GraphQLTypeCollectingVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@
import graphql.schema.GraphQLInputObjectField;
import graphql.schema.GraphQLInputObjectType;
import graphql.schema.GraphQLInterfaceType;
import graphql.schema.GraphQLList;
import graphql.schema.GraphQLNamedType;
import graphql.schema.GraphQLNonNull;
import graphql.schema.GraphQLObjectType;
import graphql.schema.GraphQLScalarType;
import graphql.schema.GraphQLSchemaElement;
Expand Down
1 change: 0 additions & 1 deletion src/main/java/graphql/schema/validation/TypeAndFieldRule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import graphql.util.TraversalControl;
import graphql.util.TraverserContext;

import java.util.Collections;
import java.util.HashSet;
import java.util.List;
import java.util.Set;
Expand Down
3 changes: 0 additions & 3 deletions src/main/java/graphql/util/Anonymizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
import graphql.language.VariableDefinition;
import graphql.language.VariableReference;
import graphql.parser.Parser;
import graphql.parser.ParserEnvironment;
import graphql.schema.GraphQLAppliedDirective;
import graphql.schema.GraphQLAppliedDirectiveArgument;
import graphql.schema.GraphQLArgument;
Expand Down Expand Up @@ -798,8 +797,6 @@ public TraversalControl visitArgument(QueryVisitorFieldArgumentEnvironment envir
}
});

AtomicInteger stringValueCounter = new AtomicInteger(1);
AtomicInteger intValueCounter = new AtomicInteger(1);
AstTransformer astTransformer = new AstTransformer();
AtomicInteger aliasCounter = new AtomicInteger(1);
AtomicInteger defaultStringValueCounter = new AtomicInteger(1);
Expand Down
1 change: 0 additions & 1 deletion src/main/java/graphql/util/TreeParallelTransformer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
import java.util.HashMap;
import java.util.LinkedHashMap;
import java.util.LinkedList;
Expand Down
1 change: 0 additions & 1 deletion src/main/java/graphql/util/TreeTransformer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import graphql.PublicApi;
import graphql.collect.ImmutableKit;

import java.util.Collections;
import java.util.LinkedList;
import java.util.List;
import java.util.Map;
Expand Down
1 change: 0 additions & 1 deletion src/main/java/graphql/validation/TraversalContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@


import graphql.Assert;
import graphql.DirectivesUtil;
import graphql.Internal;
import graphql.execution.TypeFromAST;
import graphql.language.Argument;
Expand Down
1 change: 0 additions & 1 deletion src/main/java/graphql/validation/rules/KnownArgumentNames.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import graphql.validation.AbstractRule;
import graphql.validation.ValidationContext;
import graphql.validation.ValidationErrorCollector;
import graphql.validation.ValidationErrorType;

import static graphql.validation.ValidationErrorType.UnknownArgument;
import static graphql.validation.ValidationErrorType.UnknownDirective;
Expand Down
1 change: 0 additions & 1 deletion src/main/java/graphql/validation/rules/NoUnusedVariables.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import graphql.validation.AbstractRule;
import graphql.validation.ValidationContext;
import graphql.validation.ValidationErrorCollector;
import graphql.validation.ValidationErrorType;

import java.util.ArrayList;
import java.util.LinkedHashSet;
Expand Down
X Tutup