Deprecation cleanout - programmatic schemas#2974
Merged
Conversation
dondonz
commented
Oct 2, 2022
| * | ||
| * @return a non null instrumented ExecutionContext, the default is to return to the same object | ||
| * | ||
| * @deprecated use {@link #instrumentExecutionContext(ExecutionContext, InstrumentationExecutionParameters)} instead |
Member
Author
There was a problem hiding this comment.
Was pointing to the deprecated method signature
dondonz
added
the
not release related
bbakerman
reviewed
Oct 5, 2022
| .name("floatNaN") | ||
| .type(Scalars.GraphQLFloat) | ||
| .staticValue(Double.NaN)) | ||
| .staticValue(Double.NaN)) // Retain for test coverage |
Member
There was a problem hiding this comment.
Isn't this one of the values we decided was not valid.
Member
Author
There was a problem hiding this comment.
Good catch, I'll include this in the NaN test tidy up. I can't see any test using this field at the moment
bbakerman
approved these changes
Oct 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing up deprecated API usages in programmatic test schemas, fix last few remaining Java deprecated method overrides
This is the last deprecation fix PR for tests. Next PR will fix deprecated usages in documentation examples