X Tutup
Skip to content

Remove redundant NaN check, already handled in GraphqlFloatCoercing #2936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andimarek merged 2 commits into from
Aug 29, 2022
Merged

Remove redundant NaN check, already handled in GraphqlFloatCoercing #2936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9b878b
Remove redundant NaN check, already handled in GraphqlFloatCoercing
dondonz Aug 27, 2022
b4b5174
Tidy up todos
dondonz Aug 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/main/java/graphql/execution/ExecutionStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,11 +599,6 @@ protected CompletableFuture<ExecutionResult> completeValueForScalar(ExecutionCon
serialized = handleCoercionProblem(executionContext, parameters, e);
}

// TODO: fix that: this should not be handled here
//6.6.1 http://facebook.github.io/graphql/#sec-Field-entries
if (serialized instanceof Double && ((Double) serialized).isNaN()) {
serialized = null;
}
try {
serialized = parameters.getNonNullFieldValidator().validate(parameters.getPath(), serialized);
} catch (NonNullableFieldWasNullException e) {
Expand Down
3 changes: 0 additions & 3 deletions src/test/resources/extra-large-schema-1.graphqls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -824,12 +824,10 @@ enum JiraAttachmentsPermissions {

input JiraOrderDirection {
id: ID
#TODO
}

input JiraAttachmentsOrderField {
id: ID
#TODO
}
"""
Represents the avatar size urls.
Expand Down Expand Up @@ -1655,7 +1653,6 @@ type JiraComponent implements Node {
Component description.
"""
description: String
# TODO: lead, default assignee ...
}

"""
Expand Down
X Tutup