Conversation
bbakerman
commented
Feb 17, 2022
| return ""; | ||
| } | ||
| return start + maybeString + (!isEmpty(end) ? end : ""); | ||
| return new StringBuilder().append(start).append(maybeString).append(!isEmpty(end) ? end : "").toString(); |
Member
Author
There was a problem hiding this comment.
This actually makes a difference in the benchmarks - not a lot but some
Contributor
There was a problem hiding this comment.
This may no longer be true when compiling with JDK 9, just throwing it in
https://openjdk.java.net/jeps/280
I do not know how long you want to stay on JDK 8 though, for now it is an improvement
bbakerman
commented
Feb 17, 2022
| } | ||
|
|
||
| private String indent(String maybeString) { | ||
| if (isEmpty(maybeString)) { |
Member
Author
There was a problem hiding this comment.
it was never empty - ever
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ps - this is the benchmarks but with printCompact - its still MUCH faster