Fix wrong newline on Windows in SchemaPrinter (\r\n -> \n)#2705
Fix wrong newline on Windows in SchemaPrinter (\r\n -> \n)#2705bbakerman merged 1 commit intographql-java:masterfrom
SchemaPrinter (\r\n -> \n)#2705Conversation
The printer was printing `\r\n` sequences instead of `\n`, because it was using `PrintWriter#println` Fixes the `"can print a schema as AST elements"` test in `SchemaPrinterTest.groovy` on Windows See https://docs.oracle.com/javase/8/docs/api/java/io/PrintWriter.html#println-- > The line separator string is defined by the system property line.separator, **and is not necessarily a single newline character ('\n')**.
|
But why is |
|
Yes, for text programs, but the test "can print a schema as AST elements" fails because Groovy multiline strings compile to use \n
You can see this when debugging and extracting the string to be compared to a variable Notepad and other software correctly recognize
This behaviour is only present when using |
|
Now that I am reworking the CI with Windows support you can view the error: https://github.com/jord1e/graphql-java/actions/runs/1773061590 |
|
thanks for the detailed explanation |
2 participants
The printer was printing
\r\nsequences instead of\n, because it was usingPrintWriter#printlnFixes the
"can print a schema as AST elements"test inSchemaPrinterTest.groovyon WindowsSee
https://docs.oracle.com/javase/8/docs/api/java/io/PrintWriter.html#println--