Using custom data structure for callstack tracking#2630
Merged
bbakerman merged 1 commit intographql-java:masterfrom Dec 6, 2021
Merged
Using custom data structure for callstack tracking#2630bbakerman merged 1 commit intographql-java:masterfrom
bbakerman merged 1 commit intographql-java:masterfrom
Conversation
a388455 to
1b25d41
Compare
By replacing LinkedHashMap<Integer, Integer> with a simpler int[] it is possible to observe about -80% memory consumption (avoiding a lot of primitive int boxing, better cache locality, etc).
1b25d41 to
7806ff2
Compare
bbakerman
requested changes
Dec 5, 2021
Member
bbakerman
left a comment
There was a problem hiding this comment.
Thanks very much for this PR. I am happy to accept it in the general sense but if we can tweak the naming and also have the set method that would be unreal
|
|
||
| CallStack() { | ||
| expectedStrategyCallsPerLevel.put(1, 1); | ||
| expectedStrategyCallsPerLevel.increment(1, 1); |
Member
There was a problem hiding this comment.
I think you should make another method that is a "set". The above code is "set level 1 to the value 1" whereas your code is "increment" the value by 1 (but its zero right now)
So I think a expectedStrategyCallsPerLevel.set(1) is a better method
src/main/java/graphql/execution/instrumentation/dataloader/FieldLevelTrackingApproach.java
Show resolved
Hide resolved
Member
|
Actually since this is so small - let me fix it up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@andimarek @bbakerman hello :)
I would like to propose the following optimization in
FieldLevelTrackingApproach. By using a custom data structure (a glorified int[] array), it is possible to gain some performance.I wrote 2 performance tests:
IntMapBenchmark(included in the PR) on my machine, I get 5x better performance:Output:
please have a look and let me know... I really don't like the current name as it is not a real replacement for a
Map<Integer, Integer>! :-)