Added support for a context object to the AstTransformer#2596
Merged
bbakerman merged 2 commits intographql-java:masterfrom Nov 12, 2021
Merged
Added support for a context object to the AstTransformer#2596bbakerman merged 2 commits intographql-java:masterfrom
bbakerman merged 2 commits intographql-java:masterfrom
Conversation
bbakerman
approved these changes
Oct 23, 2021
Member
bbakerman
left a comment
bbakerman
left a comment
There was a problem hiding this comment.
I would love it if you could clean up the JavaDoc to improve it please
| return TraversalControl.CONTINUE; | ||
| } | ||
| }; | ||
| public Node transform(Node root, NodeVisitor nodeVisitor, Map<Class<?>, Object> rootVars) { |
Member
There was a problem hiding this comment.
I know the previous code did not have JavaDoc but can you please fix this up.
We now have a map of variables and hence we should explain them and how one might get access to them
Contributor
Author
There was a problem hiding this comment.
Certainly, I took a stab at writing the JavaDocs for the methods I understand. I am not sure how the parallel methods operate so I did not write JavaDocs for them.
Contributor
Author
|
@bbakerman would you mind taking a second look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello from Twitter!
About
I'm working on a task for my overlord @jbellenger to prune unused fragments from a
Document. To accomplish this, I'm hoping to pass a context argument into theAstTransfromerwhich will provide the names of the nodes to prune. This seems like functionality other users may want fromAstTransfromerso I'm raising a pull request to add it.What Changed
I overloaded the
.transform()method ofAstTransformerso that it accepts a "rootVars" object, and passes it to theTreeTransformer.This is my first time contributing to graphql-java, or any open source project, so please let me know if I should add other details before raising a PR in the future. Looking forwards to working with y'all.